Received: with ECARTIS (v1.0.0; list netdev); Thu, 30 Dec 2004 14:16:15 -0800 (PST) Received: from xi.wantstofly.org (alephnull.demon.nl [212.238.201.82]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBUMFlrg008230 for ; Thu, 30 Dec 2004 14:16:08 -0800 Received: by xi.wantstofly.org (Postfix, from userid 500) id 46F1E2B0EE; Thu, 30 Dec 2004 23:24:15 +0100 (MET) Date: Thu, 30 Dec 2004 23:24:15 +0100 From: Lennert Buytenhek To: Bart De Schuymer Cc: "David S. Miller" , netdev@oss.sgi.com, snort2004@mail.ru Subject: Re: [PATCH][BRIDGE-NF] Fix wrong use of skb->protocol Message-ID: <20041230222415.GB19587@xi.wantstofly.org> References: <1104432914.15601.19.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1104432914.15601.19.camel@localhost.localdomain> User-Agent: Mutt/1.4.1i X-Virus-Scanned: ClamAV 0.80/638/Tue Dec 21 14:41:34 2004 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 13258 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: buytenh@wantstofly.org Precedence: bulk X-list: netdev On Thu, Dec 30, 2004 at 07:55:14PM +0100, Bart De Schuymer wrote: > ip_sabotage_out() needs to distinguish IPv4 and IPv6 traffic. It > currently does that by looking at skb->protocol. However, for locally > originated packets, skb->protocol is not initialized. > The patch below instead looks at the version number of the packet's > data, which should be 4 or 6. A while ago there were a number of problems with bridging CIPE ethernet devices, which turned out to be the bridge code not initialising skb->protocol for locally originated STP frames. At the time I was told that initialising skb->protocol for locally originated packets is required, so that is how I fixed it then. cheers, Lennert