Received: with ECARTIS (v1.0.0; list netdev); Thu, 30 Dec 2004 01:46:28 -0800 (PST)
Received: from lug-owl.de (lug-owl.de [195.71.106.12])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBU9jxCR008528
	for <netdev@oss.sgi.com>; Thu, 30 Dec 2004 01:46:20 -0800
Received: by lug-owl.de (Postfix, from userid 1001)
	id A0ACC1901D0; Thu, 30 Dec 2004 10:48:39 +0100 (CET)
Date: Thu, 30 Dec 2004 10:48:39 +0100
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: David Dillow <dave@thedillows.org>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state
Message-ID: <20041230094839.GX2460@lug-owl.de>
Mail-Followup-To: David Dillow <dave@thedillows.org>,
	netdev@oss.sgi.com, linux-kernel@vger.kernel.org
References: <20041230035000.01@ori.thedillows.org> <20041230035000.10@ori.thedillows.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="urKaCNvFwQ8jDQOg"
Content-Disposition: inline
In-Reply-To: <20041230035000.10@ori.thedillows.org>
X-Operating-System: Linux mail 2.6.10-rc2-bk5lug-owl 
X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444  A961 1DBD 5E75 8399 E1BB
X-gpg-key: wwwkeys.de.pgp.net
User-Agent: Mutt/1.5.6+20040907i
X-Virus-Scanned: ClamAV 0.80/638/Tue Dec 21 14:41:34 2004
	clamav-milter version 0.80j
	on 127.0.0.1
X-Virus-Status: Clean
X-archive-position: 13222
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: jbglaw@lug-owl.de
Precedence: bulk
X-list: netdev


--urKaCNvFwQ8jDQOg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, 2004-12-30 03:48:34 -0500, David Dillow <dave@thedillows.org>
wrote in message <20041230035000.10@ori.thedillows.org>:
> diff -Nru a/include/net/xfrm.h b/include/net/xfrm.h
> --- a/include/net/xfrm.h	2004-12-30 01:12:08 -05:00
> +++ b/include/net/xfrm.h	2004-12-30 01:12:08 -05:00
> @@ -146,6 +146,9 @@
>  	/* Private data of this transformer, format is opaque,
>  	 * interpreted by xfrm_type methods. */
>  	void			*data;
> +
> +	/* Intended direction of this state, used for offloading */
> +	int			dir;
>  };
> =20
>  enum {
> @@ -157,6 +160,12 @@
>  	XFRM_STATE_DEAD
>  };
> =20
> +enum {
> +	XFRM_STATE_DIR_UNKNOWN,
> +	XFRM_STATE_DIR_IN,
> +	XFRM_STATE_DIR_OUT,
> +};

Any specific reason to first define such a nice enum and then using int
in the struct?

MfG, JBG

--=20
Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481             =
_ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  =
_ _ O
 fuer einen Freien Staat voll Freier B=C3=BCrger" | im Internet! |   im Ira=
k!   O O O
ret =3D do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)=
);

--urKaCNvFwQ8jDQOg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFB0873Hb1edYOZ4bsRAtCuAJ9evP8DkQ142XphAFaMDulpbbu15gCgieXS
cBCw52xCYS6wmYrHlrMGijM=
=44jp
-----END PGP SIGNATURE-----

--urKaCNvFwQ8jDQOg--