Received: with ECARTIS (v1.0.0; list netdev); Mon, 27 Dec 2004 20:07:44 -0800 (PST) Received: from cheetah.davemloft.net (mail@adsl-63-197-226-105.dsl.snfc21.pacbell.net [63.197.226.105]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBS47H1o014964 for ; Mon, 27 Dec 2004 20:07:37 -0800 Received: from localhost ([127.0.0.1] helo=cheetah.davemloft.net ident=davem) by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian)) id 1Cj8au-0002zs-00; Mon, 27 Dec 2004 20:04:24 -0800 Date: Mon, 27 Dec 2004 20:04:24 -0800 From: "David S. Miller" To: Adrian Bunk Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] net/ipv4/: misc possible cleanups Message-Id: <20041227200424.557a5902.davem@davemloft.net> In-Reply-To: <20041228033617.GI5345@stusta.de> References: <20041215005139.GJ23151@stusta.de> <20041227191535.5edce690.davem@davemloft.net> <20041228033617.GI5345@stusta.de> X-Mailer: Sylpheed version 1.0.0rc (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/638/Tue Dec 21 14:41:34 2004 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 13084 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@davemloft.net Precedence: bulk X-list: netdev On Tue, 28 Dec 2004 04:36:17 +0100 Adrian Bunk wrote: > tcp_done doesn't call tcp_clear_xmit_timer, it calls > tcp_clear_xmit_timers (note the s) which is not an inline but an > EXPORT_SYMBOL'ed function in tcp_timer.c. My bad, I'll re-review your patch and apply it unless I find some problem.