Received: with ECARTIS (v1.0.0; list netdev); Thu, 30 Dec 2004 21:03:44 -0800 (PST) Received: from mx02.cybersurf.com (mx02.cybersurf.com [209.197.145.105]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBV53Htm026624 for ; Thu, 30 Dec 2004 21:03:37 -0800 Received: from mail.cyberus.ca ([209.197.145.21]) by mx02.cybersurf.com with esmtp (Exim 4.30) id 1CkF4l-00051n-M0 for netdev@oss.sgi.com; Fri, 31 Dec 2004 00:11:47 -0500 Received: from cpe0030ab124d2f-cm014500000962.cpe.net.cable.rogers.com ([24.103.99.32] helo=[10.0.0.9]) by mail.cyberus.ca with esmtp (Exim 4.20) id 1CkExv-0007pd-Dt; Fri, 31 Dec 2004 00:04:43 -0500 Subject: Re: [PATCH 2/9] PKT_SCHED: tc filter extension API From: jamal Reply-To: hadi@cyberus.ca To: Arnaldo Carvalho de Melo Cc: Patrick McHardy , Thomas Graf , "David S. Miller" , netdev@oss.sgi.com In-Reply-To: <41D4B3AD.9080605@conectiva.com.br> References: <20041230122652.GM32419@postel.suug.ch> <20041230123023.GO32419@postel.suug.ch> <41D4A4D2.4000109@trash.net> <41D4B3AD.9080605@conectiva.com.br> Content-Type: text/plain Organization: jamalopolous Message-Id: <1104469479.1047.227.camel@jzny.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 31 Dec 2004 00:04:39 -0500 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/645/Mon Dec 27 14:56:20 2004 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 13274 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: hadi@cyberus.ca Precedence: bulk X-list: netdev On Thu, 2004-12-30 at 21:04, Arnaldo Carvalho de Melo wrote: > > > > Please use act == NULL > > Agreed, but I understand the people who like this (ugly) style, it becomes > less likely to become an "if (act = NULL)", but hey, compilers already > helps us with a nice warning. There are certain people who would kill you for doing the above ;-> Or maybe theyll just take away your coffee. I think its a taste issue. Code looks fine either way. cheers, jamal