Received: with ECARTIS (v1.0.0; list netdev); Thu, 30 Dec 2004 20:35:22 -0800 (PST) Received: from mx03.cybersurf.com (mx03.cybersurf.com [209.197.145.106]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBV4YqLc022492 for ; Thu, 30 Dec 2004 20:35:14 -0800 Received: from mail.cyberus.ca ([209.197.145.21]) by mx03.cybersurf.com with esmtp (Exim 4.30) id 1CkEdP-0002t2-3S for netdev@oss.sgi.com; Thu, 30 Dec 2004 23:43:31 -0500 Received: from cpe0030ab124d2f-cm014500000962.cpe.net.cable.rogers.com ([24.103.99.32] helo=[10.0.0.9]) by mail.cyberus.ca with esmtp (Exim 4.20) id 1CkEdJ-0005YE-Kn; Thu, 30 Dec 2004 23:43:25 -0500 Subject: Re: [PATCH 3/9] PKT_SCHED: u32: make use of tcf_exts API From: jamal Reply-To: hadi@cyberus.ca To: Thomas Graf Cc: "David S. Miller" , Patrick McHardy , netdev@oss.sgi.com In-Reply-To: <20041230123108.GP32419@postel.suug.ch> References: <20041230122652.GM32419@postel.suug.ch> <20041230123108.GP32419@postel.suug.ch> Content-Type: text/plain Organization: jamalopolous Message-Id: <1104468201.1047.201.camel@jzny.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 30 Dec 2004 23:43:21 -0500 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/645/Mon Dec 27 14:56:20 2004 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 13268 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: hadi@cyberus.ca Precedence: bulk X-list: netdev On Thu, 2004-12-30 at 07:31, Thomas Graf wrote: > > +static struct tcf_ext_map u32_ext_map = { > + .action = TCA_U32_ACT, > + .police = TCA_U32_POLICE > +}; Repeated on all classifiers - perhaps a little macro magic in order? ;-> Generally rest all looking good - I need to stare some more at the route and tcindex one but dont see any show stoppers off hand; cheers, jamal