Received: with ECARTIS (v1.0.0; list netdev); Thu, 04 Nov 2004 10:47:52 -0800 (PST) Received: from fr.zoreil.com (electric-eye.fr.zoreil.com [213.41.134.224]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iA4Ill3t000607 for ; Thu, 4 Nov 2004 10:47:48 -0800 Received: from electric-eye.fr.zoreil.com (localhost.localdomain [127.0.0.1]) by fr.zoreil.com (8.12.10/8.12.1) with ESMTP id iA4Ijavr003034; Thu, 4 Nov 2004 19:45:36 +0100 Received: (from romieu@localhost) by electric-eye.fr.zoreil.com (8.12.10/8.12.10/Submit) id iA4IjTZ3003033; Thu, 4 Nov 2004 19:45:29 +0100 Date: Thu, 4 Nov 2004 19:45:29 +0100 From: Francois Romieu To: Jon Mason Cc: netdev@oss.sgi.com, jgarzik@pobox.com Subject: Re: [PATCH 2/3] r8169: Large Send enablement Message-ID: <20041104184529.GA2694@electric-eye.fr.zoreil.com> References: <200411021203.22003.jdmason@us.ibm.com> <20041102191103.GA24860@electric-eye.fr.zoreil.com> <200411031816.11675.jdmason@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411031816.11675.jdmason@us.ibm.com> User-Agent: Mutt/1.4.1i X-Organisation: Land of Sunshine Inc. X-archive-position: 11445 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: romieu@fr.zoreil.com Precedence: bulk X-list: netdev Content-Length: 764 Lines: 17 Jon Mason : > On Tuesday 02 November 2004 01:11 pm, Francois Romieu wrote: > [...] > > - If rtl8169_open() fails [*] when the device was previously up, the driver > > could/should try to recover. > > I disagree. It should fail, complain loudly, and let the user try and fix it > (or return it to the previous state). The code provided below will act like Mmmm... Actually both patches try to paper over the real issue: the driver should reserve the ressources it needs for the change of mtu first. Ok, I'll take the patch provided I can't find anything badly racy in it and focus on the 8139C+/8169 merge. It has already been delayed for too long and it seems the right place to fix the aforementionned issue with style :o) -- Ueimor