Received: with ECARTIS (v1.0.0; list netdev); Tue, 02 Nov 2004 11:31:45 -0800 (PST) Received: from fr.zoreil.com (electric-eye.fr.zoreil.com [213.41.134.224]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iA2JVY20018144 for ; Tue, 2 Nov 2004 11:31:35 -0800 Received: from electric-eye.fr.zoreil.com (localhost.localdomain [127.0.0.1]) by fr.zoreil.com (8.12.10/8.12.1) with ESMTP id iA2JRsvr025768; Tue, 2 Nov 2004 20:27:54 +0100 Received: (from romieu@localhost) by electric-eye.fr.zoreil.com (8.12.10/8.12.10/Submit) id iA2JRkte025766; Tue, 2 Nov 2004 20:27:46 +0100 Date: Tue, 2 Nov 2004 20:27:46 +0100 From: Francois Romieu To: Jon Mason Cc: netdev@oss.sgi.com, jgarzik@pobox.com Subject: Re: [PATCH 3/3] r8169: clean up Message-ID: <20041102192746.GB24860@electric-eye.fr.zoreil.com> References: <200411021203.25100.jdmason@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411021203.25100.jdmason@us.ibm.com> User-Agent: Mutt/1.4.1i X-Organisation: Land of Sunshine Inc. X-archive-position: 11356 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: romieu@fr.zoreil.com Precedence: bulk X-list: netdev Content-Length: 743 Lines: 23 Jon Mason : > Removal of some magic numbers, unnecessary double not, and addition of "link > down" notification. > > Signed-off-by: Jon Mason > > --- r8169.c 2004-11-02 10:37:31.035203120 -0600 > +++ r8169.c.latest 2004-11-02 10:44:01.367863536 -0600 [...] > @@ -773,7 +775,7 @@ static void rtl8169_gset_tbi(struct net_ > > status = RTL_R32(TBICSR); > cmd->advertising = (status & TBINwEnable) ? ADVERTISED_Autoneg : 0; > - cmd->autoneg = !!(status & TBINwEnable); > + cmd->autoneg = status & TBINwEnable; > > cmd->speed = SPEED_1000; > cmd->duplex = DUPLEX_FULL; /* Always set */ drivers/net/*.c use 0/1 or AUTONEG_{EN/DIS}ABLE. -- Ueimor