Received: with ECARTIS (v1.0.0; list netdev); Thu, 18 Nov 2004 10:01:51 -0800 (PST)
Received: from localhost.localdomain (clock-tower.bc.nu [81.2.110.250] (may be forged))
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iAII1jNn023645
	for <netdev@oss.sgi.com>; Thu, 18 Nov 2004 10:01:46 -0800
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by localhost.localdomain (8.12.11/8.12.11) with ESMTP id iAIGwB1A006248;
	Thu, 18 Nov 2004 16:58:11 GMT
Received: (from alan@localhost)
	by localhost.localdomain (8.12.11/8.12.11/Submit) id iAIGw9od006247;
	Thu, 18 Nov 2004 16:58:09 GMT
X-Authentication-Warning: localhost.localdomain: alan set sender to alan@lxorguk.ukuu.org.uk using -f
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when
	using SELinux and SOCK_SEQPACKET
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: James Morris <jmorris@redhat.com>
Cc: Chris Wright <chrisw@osdl.org>,
        Ross Kendall Axe <ross.axe@blueyonder.co.uk>, netdev@oss.sgi.com,
        Stephen Smalley <sds@epoch.ncsc.mil>,
        lkml <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>
In-Reply-To: <Xine.LNX.4.44.0411181219590.5236-100000@thoron.boston.redhat.com>
References: 
	 <Xine.LNX.4.44.0411181219590.5236-100000@thoron.boston.redhat.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1100797066.6019.20.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) 
Date: Thu, 18 Nov 2004 16:58:07 +0000
X-archive-position: 11952
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: alan@lxorguk.ukuu.org.uk
Precedence: bulk
X-list: netdev

On Iau, 2004-11-18 at 17:25, James Morris wrote:
> 1) Don't call security_unix_may_send() hook during sendmsg() for 
> SOCK_SEQPACKET, and ensure that sendmsg() can only be called on a 
> connected socket so as not to bypass the security_unix_stream_connect() 
> hook.
> 
> 2) Return -EINVAL if sendto() is called on SOCK_SEQPACKET with an address 
> supplied.

Consider shutdown(). A sendmsg into shutdown must return the pending
ECONNRESET
first.