Received: with ECARTIS (v1.0.0; list netdev); Tue, 09 Nov 2004 04:37:00 -0800 (PST)
Received: from lotus.znyx.com (znx208-2-156-007.znyx.com [208.2.156.7])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iA9Cas3T008855
	for <netdev@oss.sgi.com>; Tue, 9 Nov 2004 04:36:54 -0800
Received: from localhost ([208.2.156.2])
          by lotus.znyx.com (Lotus Domino Release 5.0.11)
          with ESMTP id 2004110904402481:15867 ;
          Tue, 9 Nov 2004 04:40:24 -0800 
Subject: Re: [PATCH] [TRY2] Use nfmark as a key in u32 classifier
From: jamal <hadi@cyberus.ca>
Reply-To: hadi@cyberus.ca
To: "Catalin(ux aka Dino)  "BOIE <util@deuroconsult.ro>
Cc: linux-net@vger.kernel.org, lartc@mailman.ds9a.nl, netdev@oss.sgi.com
In-Reply-To: <Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro>
References: <Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro>
Organization: jamalopolis
Message-Id: <1100003794.1114.61.camel@jzny.localdomain>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 
Date: 09 Nov 2004 07:36:34 -0500
X-MIMETrack: Itemize by SMTP Server on Lotus/Znyx(Release 5.0.11  |July 24, 2002) at 11/09/2004
 04:40:24 AM,
	Serialize by Router on Lotus/Znyx(Release 5.0.11  |July 24, 2002) at 11/09/2004
 04:40:27 AM,
	Serialize complete at 11/09/2004 04:40:27 AM
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-archive-position: 11627
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: hadi@cyberus.ca
Precedence: bulk
X-list: netdev
Content-Length: 823
Lines: 30


Looks quiet palatable. You didnt CC Dave for inclusion

cheers,
jamal

On Tue, 2004-11-09 at 07:27, Catalin(ux aka Dino) BOIE wrote:
> Hello!
> 
> This is the try number two.
> What was changed:
> - Added selectable choice in Kconfig file (thanks Jamal!)
> - Don't abuse tc_u32_sel to not break backward compatibility (thanks 
> Patrick!).
> 
> Stephen, do you have any comments on iproute2 part? I know it's not 
> perfect but this is the best way, I think. "u32 match mark vvvv mmmm" it's 
> intuitive but breaks a little the levels, "u32 mark vvvv mmmm" it's ok 
> but not intuitive....
> If you want I can rewrite it if you want.
> 
> Thank you for your time.
> 
> Signed-off-by: Catalin(ux aka Dino) <catab at umbrella.ro>
> 
> ---
> Catalin(ux aka Dino) BOIE
> catab at deuroconsult.ro
> http://kernel.umbrella.ro/