Received: with ECARTIS (v1.0.0; list netdev); Wed, 20 Oct 2004 01:09:12 -0700 (PDT) Received: from mtagate4.de.ibm.com (mtagate4.de.ibm.com [195.212.29.153]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i9K896dw002161 for ; Wed, 20 Oct 2004 01:09:07 -0700 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.12.10/8.12.10) with ESMTP id i9K88ixX064620; Wed, 20 Oct 2004 08:08:44 GMT Received: from d12ml068.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id i9K88ikJ172408; Wed, 20 Oct 2004 10:08:44 +0200 In-Reply-To: <20041019233618.6fdcb01d.davem@redhat.com> To: Ben Greear Cc: netdev@oss.sgi.com, vlan@candelatech.com MIME-Version: 1.0 Subject: Re: FWD: setting skb->dev to vlan device in vlan_hwaccel_rx is wrong ... X-Mailer: Lotus Notes Release 6.0.2CF1 June 9, 2003 From: Frank Pavlic Message-ID: Date: Wed, 20 Oct 2004 10:08:42 +0200 X-MIMETrack: Serialize by Router on D12ML068/12/M/IBM(Release 6.0.2CF2HF259 | March 11, 2004) at 20/10/2004 10:08:44, Serialize complete at 20/10/2004 10:08:44 Content-Type: text/plain; charset="US-ASCII" X-archive-position: 10509 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: PAVLIC@de.ibm.com Precedence: bulk X-list: netdev Content-Length: 683 Lines: 35 oh , I'm sorry for confusing you guys , I finally get the point on how the hw_accel_rx stuff is working ... Frank "David S. Miller" 20.10.2004 08:36 To Ben Greear cc vlan@candelatech.com, Frank Pavlic/Germany/IBM@IBMDE, netdev@oss.sgi.com Subject Re: FWD: setting skb->dev to vlan device in vlan_hwaccel_rx is wrong ... On Fri, 15 Oct 2004 16:27:46 -0700 Ben Greear wrote: > Dave, since you did the hw-accel work, what do you think of this patch? I see no mention of what specific part of the "receive path" depends upon the skb->dev being set to the real_dev and not the true VLAN device.