Received: with ECARTIS (v1.0.0; list netdev); Sat, 30 Oct 2004 15:41:57 -0700 (PDT) Received: from www.linux.org.uk (IDENT:93@parcelfarce.linux.theplanet.co.uk [195.92.249.252]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i9UMfkNH018268 for ; Sat, 30 Oct 2004 15:41:47 -0700 Received: from rdu74-155-169.nc.rr.com ([24.74.155.169] helo=[10.10.10.88]) by www.linux.org.uk with asmtp (TLSv1:AES256-SHA:256) (Exim 4.33) id 1CO1uY-0001VD-4h; Sat, 30 Oct 2004 23:41:26 +0100 Message-ID: <41841886.2080609@pobox.com> Date: Sat, 30 Oct 2004 18:41:10 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922 X-Accept-Language: en-us, en MIME-Version: 1.0 To: maximilian attems CC: Margit Schubert-While , Nishanth Aravamudan , hvr@gnu.org, mcgrof@studorgs.rutgers.edu, kernel-janitors@lists.osdl.org, prism54-devel@prism54.org, netdev@oss.sgi.com, Domen Puncer , linux-kernel@vger.kernel.org Subject: Re: [patch 2.4] back port msleep(), msleep_interruptible() References: <20040923221303.GB13244@us.ibm.com> <20040923221303.GB13244@us.ibm.com> <5.1.0.14.2.20040924074745.00b1cd40@pop.t-online.de> <415CD9D9.2000607@pobox.com> <20041030222228.GB1456@stro.at> In-Reply-To: <20041030222228.GB1456@stro.at> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 11210 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: jgarzik@pobox.com Precedence: bulk X-list: netdev maximilian attems wrote: > diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h > --- a/include/linux/delay.h~add-msleep-2.4 2004-10-30 22:48:46.000000000 +0200 > +++ b/include/linux/delay.h 2004-10-30 22:48:46.000000000 +0200 > @@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy; > ({unsigned long msec=(n); while (msec--) udelay(1000);})) > #endif > > +void msleep(unsigned int msecs); > +unsigned long msleep_interruptible(unsigned int msecs); > + > +static inline void ssleep(unsigned int seconds) [...] > +static inline unsigned int jiffies_to_msecs(const unsigned long j) > +static inline unsigned int jiffies_to_usecs(const unsigned long j) > +static inline unsigned long msecs_to_jiffies(const unsigned int m) I'm pretty sure more than one of these symbols clashes with a symbol defined locally in a driver. I like the patch but we can't apply it until the impact on existing code is evaluated. Jeff