Received: with ECARTIS (v1.0.0; list netdev); Wed, 13 Oct 2004 13:58:00 -0700 (PDT) Received: from www.linux.org.uk (IDENT:93@parcelfarce.linux.theplanet.co.uk [195.92.249.252]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i9DKvt5I018956 for ; Wed, 13 Oct 2004 13:57:56 -0700 Received: from rdu74-155-169.nc.rr.com ([24.74.155.169] helo=[10.10.10.88]) by www.linux.org.uk with asmtp (TLSv1:AES256-SHA:256) (Exim 4.33) id 1CHqBo-0002qj-Vb; Wed, 13 Oct 2004 21:57:41 +0100 Message-ID: <416D96B8.5090204@pobox.com> Date: Wed, 13 Oct 2004 16:57:28 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jesse Barnes CC: netdev@oss.sgi.com, "David S. Miller" Subject: Re: [PATCH] work around 5701 misalignment References: <200410131554.19845.jbarnes@sgi.com> In-Reply-To: <200410131554.19845.jbarnes@sgi.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 10174 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: jgarzik@pobox.com Precedence: bulk X-list: netdev Content-Length: 671 Lines: 23 Jesse Barnes wrote: > --- a/linux/drivers/net/tg3.c 2004-10-13 15:25:03.000000000 -0500 > +++ b/linux/drivers/net/tg3.c 2004-10-13 15:14:45.000000000 -0500 > @@ -2352,7 +2352,12 @@ > > len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4; /* omit crc */ > > - if (len > RX_COPY_THRESHOLD) { > + if (len > RX_COPY_THRESHOLD > +#if defined(CONFIG_UNALIGNED_EXPENSIVE) > + && tp->rx_offset == 2 > +#endif hmmm, the normal solution is to give RX_COPY_THRESHOLD a per-arch value. Grep for 'rx_copybreak' in bunches of net drivers. DaveM might squirm a bit but IMHO RX_COPY_THRESHOLD really is platform-dependent. Jeff