Received: with ECARTIS (v1.0.0; list netdev); Wed, 27 Oct 2004 04:14:12 -0700 (PDT)
Received: from phoenix.infradead.org (phoenix.infradead.org [81.187.226.98])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i9RBDpRA016473
	for <netdev@oss.sgi.com>; Wed, 27 Oct 2004 04:13:52 -0700
Received: from hch by phoenix.infradead.org with local (Exim 4.42 #1 (Red Hat Linux))
	id 1CMljy-00075S-4Q; Wed, 27 Oct 2004 12:13:18 +0100
Date: Wed, 27 Oct 2004 12:13:17 +0100
From: ext Christoph Hellwig <hch@infradead.org>
To: "Teras Timo (EXT-YomiGroup/Helsinki)" <Ext-Timo.Teras@nokia.com>
Cc: ext Christoph Hellwig <hch@infradead.org>, davem@davemloft.net,
        netdev@oss.sgi.com
Subject: Re: [PATCH] Add ability to register class interfaces for network class
Message-ID: <20041027111317.GA27240@infradead.org>
References: <20041026183526.GA23535@two.research.nokia.com> <20041026184838.GB16621@infradead.org> <20041026205239.GA23825@two.research.nokia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041026205239.GA23825@two.research.nokia.com>
User-Agent: Mutt/1.4.1i
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by phoenix.infradead.org
	See http://www.infradead.org/rpr.html
X-archive-position: 10930
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: hch@infradead.org
Precedence: bulk
X-list: netdev
Content-Length: 840
Lines: 18

> I pointed out the reason why I need it: to add an attribute:
> /sys/class/net/<interface>/<new_attribute>. Others might want to do this
> too.
> 
> Also the interface subsystem is used in many places (eg. i2o) to create
> all the sysfs entries. Maybe it'd be useful to do in net class as well.
> And if'd make separate interfaces for standard attributes and wireless
> attributes. That way you'd get rid of the #ifdefs of WIRELESS_EXT in
> net-sysfs.c.
> 
> On the other hand you didn't answer my question: why the
> interface registration should not be possible?
> Documentation/driver-model/interface.txt states that this is exactly the
> thing it should be used for.

Because we don't add interfaces for the sake of it. You still haven't show
the user that wants this.  i you presented a sane user the review would be
quite different.