Received: with ECARTIS (v1.0.0; list netdev); Wed, 20 Oct 2004 12:40:27 -0700 (PDT) Received: from ra.tuxdriver.com (ra.tuxdriver.com [24.172.12.4]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i9KJeLHH027068 for ; Wed, 20 Oct 2004 12:40:21 -0700 Received: (from linville@localhost) by ra.tuxdriver.com (8.11.6/8.11.6) id i9KIZNM14828; Wed, 20 Oct 2004 14:35:23 -0400 Date: Wed, 20 Oct 2004 14:35:23 -0400 From: "John W. Linville" To: netdev@oss.sgi.com, linux-kernel@vger.kernel.org, jgarzik@pobox.com, john.ronciak@intel.com, ganesh.venkatesan@intel.com Subject: Re: [patch 2.6.9 3/11] e1000: Add MODULE_VERSION Message-ID: <20041020143523.Q8775@tuxdriver.com> Mail-Followup-To: netdev@oss.sgi.com, linux-kernel@vger.kernel.org, jgarzik@pobox.com, john.ronciak@intel.com, ganesh.venkatesan@intel.com References: <20041020141146.C8775@tuxdriver.com> <20041020141657.F8775@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20041020141657.F8775@tuxdriver.com>; from linville@tuxdriver.com on Wed, Oct 20, 2004 at 02:16:57PM -0400 X-archive-position: 10548 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: linville@tuxdriver.com Precedence: bulk X-list: netdev Content-Length: 1008 Lines: 30 Add MODULE_VERSION to e1000 driver. Signed-off-by: John W. Linville --- drivers/net/e1000/e1000_main.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) Re-send -- forgot Signed-off-by line... --- linux-2.6.9/drivers/net/e1000/e1000_main.c.orig +++ linux-2.6.9/drivers/net/e1000/e1000_main.c @@ -48,7 +48,8 @@ char e1000_driver_string[] = "Intel(R) P #else #define DRIVERNAPI "-NAPI" #endif -char e1000_driver_version[] = "5.3.19-k2"DRIVERNAPI; +#define DRV_VERSION "5.3.19-k2"DRIVERNAPI +char e1000_driver_version[] = DRV_VERSION; char e1000_copyright[] = "Copyright (c) 1999-2004 Intel Corporation."; /* e1000_pci_tbl - PCI Device ID Table @@ -196,6 +197,7 @@ static struct pci_driver e1000_driver = MODULE_AUTHOR("Intel Corporation, "); MODULE_DESCRIPTION("Intel(R) PRO/1000 Network Driver"); MODULE_LICENSE("GPL"); +MODULE_VERSION(DRV_VERSION); static int debug = NETIF_MSG_DRV | NETIF_MSG_PROBE; module_param(debug, int, 0);