Received: with ECARTIS (v1.0.0; list netdev); Tue, 12 Oct 2004 11:10:20 -0700 (PDT) Received: from waste.org (waste.org [209.173.204.2]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i9CIABqj000739 for ; Tue, 12 Oct 2004 11:10:12 -0700 Received: from waste.org (localhost [127.0.0.1]) by waste.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id i9CI9nWk032192; Tue, 12 Oct 2004 13:09:49 -0500 Received: (from oxymoron@localhost) by waste.org (8.12.3/8.12.3/Debian-7.1) id i9CI9nI2032187; Tue, 12 Oct 2004 13:09:49 -0500 Date: Tue, 12 Oct 2004 13:09:49 -0500 From: Matt Mackall To: Con Kolivas Cc: netdev@oss.sgi.com, linux kernel mailing list , davem@redhat.com Subject: Re: [PATCH] netconsole support for b44 Message-ID: <20041012180949.GW5414@waste.org> References: <416BC26B.6090603@kolivas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <416BC26B.6090603@kolivas.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new X-archive-position: 10153 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: mpm@selenic.com Precedence: bulk X-list: netdev Content-Length: 860 Lines: 26 On Tue, Oct 12, 2004 at 09:39:23PM +1000, Con Kolivas wrote: > This patch adds poll support to the b44 driver to allow netconsole > support. Style lifted straight from 8139too.c > > here is the dmesg output with it in place: > > netconsole: device eth0 not up yet, forcing it > netconsole: carrier detect appears flaky, waiting 10 seconds > b44: eth0: Link is down. > b44: eth0: Link is up at 100 Mbps, full duplex. > b44: eth0: Flow control is on for TX and on for RX. > netconsole: network logging started > > output confirmed by netcat on other system. > > Signed-off-by: Con Kolivas + disable_irq(dev->irq); + b44_interrupt (dev->irq, dev, NULL); + enable_irq(dev->irq); Aside from this bizarre whitespace convention and neglecting to cc: me, looks good. -- Mathematics is the supreme nostalgia of our time.