Received: with ECARTIS (v1.0.0; list netdev); Fri, 01 Oct 2004 15:21:11 -0700 (PDT) Received: from cheetah.davemloft.net (mail@adsl-63-197-226-105.dsl.snfc21.pacbell.net [63.197.226.105]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i91ML4Hq005516 for ; Fri, 1 Oct 2004 15:21:04 -0700 Received: from localhost ([127.0.0.1] helo=cheetah.davemloft.net ident=davem) by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian)) id 1CDVkJ-00084W-00; Fri, 01 Oct 2004 15:19:23 -0700 Date: Fri, 1 Oct 2004 15:19:23 -0700 From: "David S. Miller" To: Yasuyuki Kozakai Cc: netdev@oss.sgi.com, usagi-core@linux-ipv6.org Subject: Re: [PATCH]: fixed typo of reassembly.c Message-Id: <20041001151923.261b42b3.davem@davemloft.net> In-Reply-To: <200409301023.i8UANRGp002783@toshiba.co.jp> References: <200409301023.i8UANRGp002783@toshiba.co.jp> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 9784 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@davemloft.net Precedence: bulk X-list: netdev On Thu, 30 Sep 2004 19:23:26 +0900 (JST) Yasuyuki Kozakai wrote: > This patch fixes byte ordering. Please apply this. It is textual fix only, do you realize this? Both ntohs() and htons() perform the same transformation on a 16-bit data item. It really does not matter which one you actually use, in practice. I will apply your patch anyways, I just wanted to be clear that this does not actually fix any bug. :-) THanks.