Received: with ECARTIS (v1.0.0; list netdev); Wed, 08 Sep 2004 21:27:19 -0700 (PDT) Received: from smtp105.mail.sc5.yahoo.com (smtp105.mail.sc5.yahoo.com [66.163.169.225]) by oss.sgi.com (8.13.0/8.13.0) with SMTP id i894RDAg010214 for ; Wed, 8 Sep 2004 21:27:13 -0700 Received: from unknown (HELO cheetah.davemloft.net) (davem?330@63.197.226.105 with login) by smtp105.mail.sc5.yahoo.com with SMTP; 9 Sep 2004 04:27:03 -0000 Date: Wed, 8 Sep 2004 21:26:59 -0700 From: "David S. Miller" To: Wolfgang Walter Cc: netdev@oss.sgi.com, greearb@candelatech.com, shemminger@osdl.org Subject: Re: Bad: scheduling while atomic! in 2.6.8.1 Message-Id: <20040908212659.4cd99935.davem@davemloft.net> In-Reply-To: <200409082342.37273.wolfgang.walter@studentenwerk.mhn.de> References: <200409082342.37273.wolfgang.walter@studentenwerk.mhn.de> Organization: DaveM Loft Enterprises X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 8540 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@davemloft.net Precedence: bulk X-list: netdev Content-Length: 1318 Lines: 41 On Wed, 8 Sep 2004 23:42:37 +0200 Wolfgang Walter wrote: > We see the exactly the same with 2.6.8.1. > > Our host has 3 nics (all 3 are intel e100). We are using vlan, iptables (no > nat or connection tracking, though) and ipsec. We tested it on other hardware > (different mainboard, different nics) and the problem remains. > > We are getting the log for every received packet, doesn't matter if these are > dhcp-requests, pings or something else. You have CONFIG_PREEMPT enabled don't you? This should fix it, it's a bug in Stephen's conversion of the VLAN code over to use RCU locking. # This is a BitKeeper generated diff -Nru style patch. # # ChangeSet # 2004/09/08 21:07:49-07:00 davem@nuts.davemloft.net # [VLAN]: Fix thinko in RCU locking. # # Signed-off-by: David S. Miller # # net/8021q/vlan_dev.c # 2004/09/08 21:07:19-07:00 davem@nuts.davemloft.net +1 -1 # [VLAN]: Fix thinko in RCU locking. # diff -Nru a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c --- a/net/8021q/vlan_dev.c 2004-09-08 21:08:30 -07:00 +++ b/net/8021q/vlan_dev.c 2004-09-08 21:08:30 -07:00 @@ -244,7 +244,7 @@ /* TODO: Add a more specific counter here. */ stats->rx_errors++; } - rcu_read_lock(); + rcu_read_unlock(); return 0; }