Received: with ECARTIS (v1.0.0; list netdev); Wed, 04 Aug 2004 06:28:35 -0700 (PDT) Received: from www.legaleagle.de (legaleagle.de [217.160.128.82]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i74DSOXS008179 for ; Wed, 4 Aug 2004 06:28:30 -0700 Received: from eru.coreworks.de (unknown [172.16.0.2]) by www.legaleagle.de (Postfix) with ESMTP id 74D3519F356; Wed, 4 Aug 2004 15:28:15 +0200 (CEST) Received: from trash.net (unknown [172.16.0.123]) by eru.coreworks.de (Postfix) with ESMTP id B2488394133; Wed, 4 Aug 2004 15:28:14 +0200 (CEST) Message-ID: <4110E505.1010205@trash.net> Date: Wed, 04 Aug 2004 15:30:45 +0200 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5 X-Accept-Language: en MIME-Version: 1.0 To: Tomasz Paszkowski Cc: davem@redhat.com, netdev@oss.sgi.com Subject: Re: [PATCH 2.4] Use double-linked list for dev->qdisc_list References: <20040804125926.GA15324@krezus.e-wro.net> In-Reply-To: <20040804125926.GA15324@krezus.e-wro.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 7493 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: kaber@trash.net Precedence: bulk X-list: netdev Content-Length: 729 Lines: 27 Tomasz Paszkowski wrote: >This patch changes dev->qdisc_list to a double-linked list. This solves >the performance problems when destroying qdiscs with large number of inner >qdiscs. > >This is backported version of Patrick McHardy patch (03-qdisc_list-list_h.diff) >or 2.6 kernels. > > Looks good, except for the last hunk, the BUG_TRAP is valid in 2.4 because it doesn't use RCU. Change it to BUG_TRAP(list_empty(&dev->qdisc_list)). > > >------------------------------------------------------------------------ > > #endif >- BUG_TRAP(dev->qdisc_list == NULL); > BUG_TRAP(!timer_pending(&dev->watchdog_timer)); >- dev->qdisc_list = NULL; > spin_unlock_bh(&dev->queue_lock); > write_unlock(&qdisc_tree_lock); > } > >