Received: with ECARTIS (v1.0.0; list netdev); Sat, 21 Aug 2004 01:36:54 -0700 (PDT) Received: from baikonur.stro.at (baikonur.stro.at [213.239.196.228]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i7L8al5U003810 for ; Sat, 21 Aug 2004 01:36:48 -0700 Received: from localhost (localhost [127.0.0.1]) by baikonur.stro.at (Postfix) with ESMTP id B26255C00A; Sat, 21 Aug 2004 10:36:39 +0200 (CEST) Received: from baikonur.stro.at ([127.0.0.1]) by localhost (baikonur [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 24399-10; Sat, 21 Aug 2004 10:36:39 +0200 (CEST) Received: from sputnik (M769P020.adsl.highway.telekom.at [62.47.128.20]) by baikonur.stro.at (Postfix) with ESMTP id 18D765C008; Sat, 21 Aug 2004 10:36:39 +0200 (CEST) Received: from max by sputnik with local (Exim 4.34) id 1ByRMd-0001dK-OR; Sat, 21 Aug 2004 10:36:39 +0200 Date: Sat, 21 Aug 2004 10:36:39 +0200 From: maximilian attems To: Jay Bourque Cc: kernel-janitors@lists.osdl.org, netdev@oss.sgi.com Subject: Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx Message-ID: <20040821083639.GA1827@stro.at> Mail-Followup-To: Jay Bourque , kernel-janitors@lists.osdl.org, netdev@oss.sgi.com References: <411E62D3.8070808@uranium235.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <411E62D3.8070808@uranium235.org> User-Agent: Mutt/1.5.6+20040722i X-Virus-Scanned: by Amavis (ClamAV) at stro.at X-archive-position: 7944 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: janitor@sternwelten.at Precedence: bulk X-list: netdev Content-Length: 1008 Lines: 35 On Sat, 14 Aug 2004, Jay Bourque wrote: > Fix to update last_rx after netif_rx > This is my first patch so I'd appreciate any feedback. > > -Jay > > --- linux-2.6.8.1/net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004 > +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 > @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb) > nf_reset(skb); > ipgre_ecn_decapsulate(iph, skb); > netif_rx(skb); > + tunnel->dev->last_rx = jiffies; > read_unlock(&ipgre_lock); > return(0); > } doesn't look complete, see patch below, but please read on: the kj todo has an entry about "update last_rx after netif_rx", i wonder what that timestamping is good for, and newer sources 2.4.27 and 2.6.8 show 2 occurences of last_rx. patches doing that are for young 2.4: http://seclists.org/linux-kernel/2001/Feb/4846.html i presume that this task is outdated, thanks for putting light on that. -- maks kernel janitor http://janitor.kernelnewbies.org/