Received: with ECARTIS (v1.0.0; list netdev); Wed, 04 Aug 2004 13:47:00 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i74KkpYU020579 for ; Wed, 4 Aug 2004 13:46:51 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i74Kkae1012139; Wed, 4 Aug 2004 16:46:41 -0400 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i74KkZa31397; Wed, 4 Aug 2004 16:46:35 -0400 Received: from cheetah.davemloft.net (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11/8.12.10) with SMTP id i74KjoYB027757; Wed, 4 Aug 2004 16:45:51 -0400 Date: Wed, 4 Aug 2004 13:44:32 -0700 From: "David S. Miller" To: Tomasz Paszkowski Cc: kaber@trash.net, netdev@oss.sgi.com Subject: Re: [PATCH 2.4] Use double-linked list for dev->qdisc_list Message-Id: <20040804134432.40500c15.davem@redhat.com> In-Reply-To: <20040804145610.GA21339@krezus.e-wro.net> References: <20040804125926.GA15324@krezus.e-wro.net> <4110E505.1010205@trash.net> <20040804145610.GA21339@krezus.e-wro.net> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 7514 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev Content-Length: 478 Lines: 13 On Wed, 4 Aug 2004 16:56:10 +0200 Tomasz Paszkowski wrote: > On Wed, Aug 04, 2004 at 03:30:45PM +0200, Patrick McHardy wrote: > > Looks good, except for the last hunk, the BUG_TRAP is valid in 2.4 because > > it doesn't use RCU. Change it to BUG_TRAP(list_empty(&dev->qdisc_list)). > > Thanks. In attachment there's a corrected version of this patch. Can someone regenerate this patch with the q_idx fix Patrick just posted added to it? Thanks.