Received: with ECARTIS (v1.0.0; list netdev); Mon, 02 Aug 2004 17:13:03 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i730Cw08026236 for ; Mon, 2 Aug 2004 17:12:58 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i730Coe1016484; Mon, 2 Aug 2004 20:12:50 -0400 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i730Coa29031; Mon, 2 Aug 2004 20:12:50 -0400 Received: from cheetah.davemloft.net (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11/8.12.10) with SMTP id i730C7SI016381; Mon, 2 Aug 2004 20:12:07 -0400 Date: Mon, 2 Aug 2004 17:11:26 -0700 From: "David S. Miller" To: Herbert Xu Cc: netdev@oss.sgi.com Subject: Re: [2/2] [IPSEC] Move xfrm[46]_tunnel_check_size into xfrm[46]_output.c Message-Id: <20040802171126.09dc4887.davem@redhat.com> In-Reply-To: <20040802093500.GA19747@gondor.apana.org.au> References: <20040802093153.GA19706@gondor.apana.org.au> <20040802093500.GA19747@gondor.apana.org.au> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 7435 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev On Mon, 2 Aug 2004 19:35:00 +1000 Herbert Xu wrote: > This patch moves xfrm[46]_tunnel_check_size() into xfrm[46]_output.c > where it can be made static since it's only used there. > > While moving the icmp.h inclusions over I also discovered that the > tunnel files are missing an inclusion of net/protocol.h. So I've > added them as well. The net/xfrm.h hunk failed, but I fixed that up by hand. Applied, thanks.