Received: with ECARTIS (v1.0.0; list netdev); Thu, 22 Jul 2004 18:03:54 -0700 (PDT)
Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i6N13mYg015383
	for <netdev@oss.sgi.com>; Thu, 22 Jul 2004 18:03:49 -0700
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6N13Je1009099;
	Thu, 22 Jul 2004 21:03:19 -0400
Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6N13Ja00741;
	Thu, 22 Jul 2004 21:03:19 -0400
Received: from cheetah.davemloft.net (localhost.localdomain [127.0.0.1])
	by devserv.devel.redhat.com (8.12.11/8.12.10) with SMTP id i6N12eIo010139;
	Thu, 22 Jul 2004 21:02:41 -0400
Date: Thu, 22 Jul 2004 18:03:17 -0700
From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: kaber@trash.net, shemminger@osdl.org, netdev@oss.sgi.com, devik@cdi.cz
Subject: Re: [PATCH 2.6]: Make packet scheduler clock source configurable
Message-Id: <20040722180317.0b2ae203.davem@redhat.com>
In-Reply-To: <41006344.3070402@trash.net>
References: <40F34740.5040100@trash.net>
	<1107.63.170.215.71.1089689716.squirrel@www.osdl.org>
	<20040712205037.573411c0.davem@redhat.com>
	<40F4862D.3070802@trash.net>
	<40F4AC8B.40706@trash.net>
	<20040721143110.4ab944bf.davem@redhat.com>
	<41004F76.1080807@trash.net>
	<20040722171752.341d2476.davem@redhat.com>
	<41006150.9000702@trash.net>
	<41006344.3070402@trash.net>
X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu)
X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-archive-position: 7099
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@redhat.com
Precedence: bulk
X-list: netdev

On Fri, 23 Jul 2004 03:00:52 +0200
Patrick McHardy <kaber@trash.net> wrote:

> Patrick McHardy wrote:
> > David S. Miller wrote:
> >> We could bug check this in psched calibration, in fact I think
> >> we should.
> > 
> > 
> > Done by this patch. I used BUG_ON instead of just printing a warning
> > because using packet schedulers after this error will cause a division
> > by zero.
> 
> Please drop this patch, psched_calibrate_clock already checks if
> rdelay > delay a couple of lines above.

Ok.