Received: with ECARTIS (v1.0.0; list netdev); Wed, 21 Jul 2004 16:19:45 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i6LNJaLi019264 for ; Wed, 21 Jul 2004 16:19:39 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6LNJQe1029770; Wed, 21 Jul 2004 19:19:26 -0400 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6LNJPa32279; Wed, 21 Jul 2004 19:19:25 -0400 Received: from cheetah.davemloft.net (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11/8.12.10) with SMTP id i6LNImpU014006; Wed, 21 Jul 2004 19:18:49 -0400 Date: Wed, 21 Jul 2004 16:15:20 -0700 From: "David S. Miller" To: "chas williams (contractor)" Cc: netdev@oss.sgi.com, shemminger@osdl.org Subject: Re: [PATCH] br2684 - use try_module_get appropriately Message-Id: <20040721161520.39541ccd.davem@redhat.com> In-Reply-To: <200407192136.i6JLa4QO028602@ginger.cmf.nrl.navy.mil> References: <20040628093317.218220fe@dell_ss3.pdx.osdl.net> <200407192136.i6JLa4QO028602@ginger.cmf.nrl.navy.mil> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 7071 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev Content-Length: 307 Lines: 10 On Mon, 19 Jul 2004 17:36:05 -0400 "chas williams (contractor)" wrote: > In message <20040628093317.218220fe@dell_ss3.pdx.osdl.net>,Stephen Hemminger wr > ites: > >Either way, just an (void) try_module_get() is WRONG. > > dave, please apply to 2.6 --thanks Applied, thanks guys.