Received: with ECARTIS (v1.0.0; list netdev); Tue, 08 Jun 2004 11:42:22 -0700 (PDT) Received: from orsfmr001.jf.intel.com (fmr12.intel.com [134.134.136.15]) by oss.sgi.com (8.12.10/8.12.9) with SMTP id i58IgGgi008393 for ; Tue, 8 Jun 2004 11:42:16 -0700 Received: from petasus.jf.intel.com (petasus.jf.intel.com [10.7.209.6]) by orsfmr001.jf.intel.com (8.12.9-20030918-01/8.12.9/d: major-outer.mc,v 1.15 2004/01/30 18:16:28 root Exp $) with ESMTP id i58BewUn008492; Tue, 8 Jun 2004 11:41:30 GMT Received: from orsmsxvs041.jf.intel.com (orsmsxvs041.jf.intel.com [192.168.65.54]) by petasus.jf.intel.com (8.12.9-20030918-01/8.12.9/d: major-inner.mc,v 1.10 2004/03/01 19:21:36 root Exp $) with SMTP id i58IfvEn028155; Tue, 8 Jun 2004 18:42:06 GMT Received: from orsmsx331.amr.corp.intel.com ([192.168.65.56]) by orsmsxvs041.jf.intel.com (SAVSMTP 3.1.2.35) with SMTP id M2004060811405812296 ; Tue, 08 Jun 2004 11:40:58 -0700 Received: from orsmsx408.amr.corp.intel.com ([192.168.65.52]) by orsmsx331.amr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 8 Jun 2004 11:40:58 -0700 X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: RE: [PATCH] e1000 module parameter incompatiablity Date: Tue, 8 Jun 2004 11:40:57 -0700 Message-ID: <468F3FDA28AA87429AD807992E22D07E0158A420@orsmsx408> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] e1000 module parameter incompatiablity Thread-Index: AcRNgw6a0rVs5mTxQyS9Lvf5Ec8PqgABQsWQ From: "Venkatesan, Ganesh" To: "Stephen Hemminger" Cc: "cramerj" , "Ronciak, John" , "Jeff Garzik" , X-OriginalArrivalTime: 08 Jun 2004 18:40:58.0995 (UTC) FILETIME=[241C6C30:01C44D88] X-Scanned-By: MIMEDefang 2.31 (www . roaringpenguin . com / mimedefang) Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by oss.sgi.com id i58IgGgi008393 X-archive-position: 5767 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: ganesh.venkatesan@intel.com Precedence: bulk X-list: netdev Content-Length: 1222 Lines: 44 Applied to our development tree. Thanks, ganesh ------------------------------------------------- Ganesh Venkatesan Network/Storage Division, Hillsboro, OR -----Original Message----- From: Stephen Hemminger [mailto:shemminger@osdl.org] Sent: Tuesday, June 08, 2004 11:04 AM To: Venkatesan, Ganesh Cc: cramerj; Ronciak, John; Jeff Garzik; netdev@oss.sgi.com Subject: [PATCH] e1000 module parameter incompatiablity E1000 driver is mixing new style 'module_param' with old style 'MODULE_PARM' this generates the runtime warning e1000: Ignoring new-style parameters in presence of obsolete ones and prevents using module parameters to set ring size. Signed-off-by: Stephen Hemminger diff -Nru a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c --- a/drivers/net/e1000/e1000_main.c 2004-06-08 11:01:58 -07:00 +++ b/drivers/net/e1000/e1000_main.c 2004-06-08 11:01:58 -07:00 @@ -202,8 +202,8 @@ MODULE_DESCRIPTION("Intel(R) PRO/1000 Network Driver"); MODULE_LICENSE("GPL"); -static int debug = 3; -module_param(debug, int, 0); +static int debug = NETIF_MSG_DRV | NETIF_MSG_PROBE; +MODULE_PARM(debug, "i"); MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); /**