Received: with ECARTIS (v1.0.0; list netdev); Tue, 08 Jun 2004 11:39:40 -0700 (PDT) Received: from www.linux.org.uk (IDENT:93@parcelfarce.linux.theplanet.co.uk [195.92.249.252]) by oss.sgi.com (8.12.10/8.12.9) with SMTP id i58IdYgi007972 for ; Tue, 8 Jun 2004 11:39:35 -0700 Received: from rdu74-153-143.nc.rr.com ([24.74.153.143] helo=pobox.com) by www.linux.org.uk with asmtp (TLSv1:AES256-SHA:256) (Exim 4.33) id 1BXlVV-0006aV-Kx; Tue, 08 Jun 2004 19:39:33 +0100 Message-ID: <40C607D9.5090506@pobox.com> Date: Tue, 08 Jun 2004 14:39:21 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Stephen Hemminger CC: "Venkatesan, Ganesh" , cramerj , "Ronciak, John" , netdev@oss.sgi.com Subject: Re: [PATCH] e1000 module parameter incompatiablity References: <468F3FDA28AA87429AD807992E22D07E0158A1CD@orsmsx408> <20040608110420.3b93338d@dell_ss3.pdx.osdl.net> In-Reply-To: <20040608110420.3b93338d@dell_ss3.pdx.osdl.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 5766 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: jgarzik@pobox.com Precedence: bulk X-list: netdev Content-Length: 354 Lines: 11 Stephen Hemminger wrote: > E1000 driver is mixing new style 'module_param' with old style 'MODULE_PARM' > this generates the runtime warning > e1000: Ignoring new-style parameters in presence of obsolete ones > and prevents using module parameters to set ring size. > > Signed-off-by: Stephen Hemminger why not fix the others?