Received: with ECARTIS (v1.0.0; list netdev); Fri, 07 May 2004 08:15:17 -0700 (PDT) Received: from phoenix.infradead.org (phoenix.infradead.org [213.86.99.234]) by oss.sgi.com (8.12.10/8.12.9) with SMTP id i47FF8KO009644 for ; Fri, 7 May 2004 08:15:08 -0700 Received: from hch by phoenix.infradead.org with local (Exim 4.30 #5 (Red Hat Linux)) id 1BM73w-00086f-4A; Fri, 07 May 2004 16:14:56 +0100 Date: Fri, 7 May 2004 16:14:56 +0100 From: Christoph Hellwig To: James Morris Cc: "David S. Miller" , Stephen Smalley , Chris Wright , linux-kernel@vger.kernel.org, netdev@oss.sgi.com, selinux@tycho.nsa.gov Subject: Re: [PATCH][SELINUX] 2/2 sock_create_lite() Message-ID: <20040507161455.A31114@infradead.org> Mail-Followup-To: Christoph Hellwig , James Morris , "David S. Miller" , Stephen Smalley , Chris Wright , linux-kernel@vger.kernel.org, netdev@oss.sgi.com, selinux@tycho.nsa.gov References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from jmorris@redhat.com on Fri, May 07, 2004 at 11:06:04AM -0400 X-archive-position: 5044 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: netdev On Fri, May 07, 2004 at 11:06:04AM -0400, James Morris wrote: > This patch adds a function sock_create_lite(), deprecating kernel-wide use > of sock_alloc(), which has been made static to net/socket.c. We're in the stable series and removing exported APIs there shoudn't happen. Given that sock_alloc() is actually okay for every normal use I don't think there's enough reason to remove it from the API. > +int sock_create_lite(int family, int type, int protocol, struct socket **res) Should probably be called __sock_create according to linux naming rules. Also I guess you should actually call it from sock_create instead of duplicating the code.