Received: with ECARTIS (v1.0.0; list netdev); Sun, 28 Mar 2004 18:44:54 -0800 (PST)
Received: from mail.osdl.org (fw.osdl.org [65.172.181.6])
	by oss.sgi.com (8.12.10/8.12.9) with SMTP id i2T2ipKO017029
	for <netdev@oss.sgi.com>; Sun, 28 Mar 2004 18:44:52 -0800
Received: from localhost (build.pdx.osdl.net [172.20.1.2])
	by mail.osdl.org (8.11.6/8.11.6) with ESMTP id i2T2iU227612;
	Sun, 28 Mar 2004 18:44:30 -0800
Date: Sun, 28 Mar 2004 18:44:29 -0800 (PST)
From: Linus Torvalds <torvalds@osdl.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>, Frank Denis <jedi@orbus.fr>
cc: David S Miller <davem@redhat.com>, Neil Brown <neilb@cse.unsw.edu.au>,
        Andrew Morton <akpm@osdl.org>, netdev@oss.sgi.com
Subject: Re: nfsd oops with 2.6.5-rc2-mm4
In-Reply-To: <1080511633.5553.29.camel@lade.trondhjem.org>
Message-ID: <Pine.LNX.4.58.0403281840011.1096@ppc970.osdl.org>
References: <20040327130757.GA6760@c9x.org>  <Pine.LNX.4.58.0403271816450.20100@ppc970.osdl.org>
 <1080511633.5553.29.camel@lade.trondhjem.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-archive-position: 4307
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: torvalds@osdl.org
Precedence: bulk
X-list: netdev
Content-Length: 525
Lines: 16



On Sun, 28 Mar 2004, Trond Myklebust wrote:
> 
> I'm not really that familiar with Neil's code, but looking at
> encode_entry(), shouldn't it test for the buffer overflow condition
> whereby pn >= cd->rqstp->rq_resused, and exit if it does? Neil?

Ok, I took Neils patch, which touches the same function, but looks very 
different.

Frank, can you test the current top-of-BK tree (or if not a BK user, try
the snapshot tomorrow that should get build at 2AM tonight). It would be 
good to get this thing confirmed.

		Linus