Received: with ECARTIS (v1.0.0; list netdev); Mon, 17 Nov 2003 06:40:49 -0800 (PST)
Received: from gw.localnet (port-212-202-185-245.reverse.qdsl-home.de [212.202.185.245])
	by oss.sgi.com (8.12.10/8.12.10) with SMTP id hAHEeD25025945
	for <netdev@oss.sgi.com>; Mon, 17 Nov 2003 06:40:34 -0800
Received: from ws.localnet ([192.168.0.23] helo=trash.net)
	by gw.localnet with esmtp (Exim 3.36 #1 (Debian))
	id 1ALkY3-0008E5-00; Mon, 17 Nov 2003 15:40:15 +0100
Message-ID: <3FB8DDE0.1070105@trash.net>
Date: Mon, 17 Nov 2003 15:40:32 +0100
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031107 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: hadi@cyberus.ca
CC: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH]: Adjust qlen when grafting in multiple qdiscs
References: <3FB3996A.6080008@trash.net> <1069076786.1075.19.camel@jzny.localdomain>
In-Reply-To: <1069076786.1075.19.camel@jzny.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-archive-position: 1475
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: kaber@trash.net
Precedence: bulk
X-list: netdev

Hi Jamal,

I've tested tbf and prio changes before and after. Unfortunately I've 
never used dsmark so I didn't test this part. I did try to make sure
my changes make sense, and I still don't see why this wouldn't be
correct. dsmark increments sch->q.qlen in enqueue, so it needs to
adjust it in dsmark_graft if the old queue is non-empty. If this is
wrong, please enlighten me so I can fix my patch.

Best regards,
Patrick


jamal wrote:

>Did you test some of this stuff or just did a mass-edit? I havent paid
>attention to all the details, but what would decrementing sch->q.qlen on
>grafting mean on a dsmark? 
>
>cheers,
>jamal
>
>  
>