Received: with ECARTIS (v1.0.0; list netdev); Mon, 03 Nov 2003 14:51:13 -0800 (PST)
Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242])
	by oss.sgi.com (8.12.10/8.12.10) with SMTP id hA3MoI25019437
	for <netdev@oss.sgi.com>; Mon, 3 Nov 2003 14:50:38 -0800
Received: (from davem@localhost)
	by pizda.ninka.net (8.9.3/8.9.3) id OAA16260;
	Mon, 3 Nov 2003 14:45:21 -0800
Date: Mon, 3 Nov 2003 14:45:21 -0800
From: "David S. Miller" <davem@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: anton@samba.org, kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com
Subject: Re: net/core/flow.c cpu handling?
Message-Id: <20031103144521.0aec9ea3.davem@redhat.com>
In-Reply-To: <20031103102829.E1C622C05E@lists.samba.org>
References: <20031101225050.4de96a8b.davem@redhat.com>
	<20031103102829.E1C622C05E@lists.samba.org>
X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.6; sparc-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-archive-position: 1192
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@redhat.com
Precedence: bulk
X-list: netdev

On Mon, 03 Nov 2003 21:26:40 +1100
Rusty Russell <rusty@rustcorp.com.au> wrote:

> In message <20031101225050.4de96a8b.davem@redhat.com> you write:
> > 
> > Very likely, the code is how it is in order to make the
> > 2.4.x backport of this code and the 2.6.x version as
> > similar as humanly possible.
> 
> Hmm, AFAICT the patch I sent should be easier, not harder to backport.
> 
> Anyway, I'm carrying the patch as part of the hotplug CPU patches: we
> can discuss it once 2.6.0 is out.

I intend to review your patch today, there is no justification
for the problems you've pointed out in this code regardless of
how difficult or easy fixing it makes a backport.