Received: with ECARTIS (v1.0.0; list netdev); Sun, 12 Oct 2003 20:15:14 -0700 (PDT) Received: from mail.osdl.org (fw.osdl.org [65.172.181.6]) by oss.sgi.com (8.12.10/8.12.10) with SMTP id h9D3Ec25021000 for ; Sun, 12 Oct 2003 20:14:39 -0700 Received: from midway.verizon.net (build.pdx.osdl.net [172.20.1.2]) by mail.osdl.org (8.11.6/8.11.6) with SMTP id h9D3EUo21981; Sun, 12 Oct 2003 20:14:30 -0700 Date: Sun, 12 Oct 2003 20:13:16 -0700 From: "Randy.Dunlap" To: "Noah J. Misch" Cc: netdev@oss.sgi.com, davem@redhat.com, elmer@ylenurme.ee, Elmer.Joandi@ut.ee Subject: Re: patches for PROC_FS=n (2.6.0-test7) Message-Id: <20031012201316.7ecf73c8.rddunlap@osdl.org> In-Reply-To: References: Organization: OSDL X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 760 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: rddunlap@osdl.org Precedence: bulk X-list: netdev On Fri, 10 Oct 2003 16:06:29 -0700 (PDT) "Noah J. Misch" wrote: | > There are several other drivers/protocols that don't build | > with PROC_FS=n, like arlan, siimage, ipx, llc, and bluetooth. Here's a patch for the wireless/arlan driver for PROC_FS=n. Currently it defines both a function and a macro for init_arlan_proc() if PROC_FS=n. This causes a bunch of compile-time errors. It looks to me like it should always call the init_arlan_proc() (and cleanup_arlan_proc()) functions since it inits some sysctl tables. Or am I misunderstanding it? Thanks, -- ~Randy patch_name: arlan_noprocfs.patch patch_version: 2003-10-12.19:46:24 author: Randy.Dunlap description: use init_arlan_proc() for sysctl inits product: Linux product_versions: 2.6.0-test7 diffstat: = drivers/net/wireless/arlan.h | 5 ----- 1 files changed, 5 deletions(-) diff -Naur ./drivers/net/wireless/arlan.h~arlanprocfs ./drivers/net/wireless/arlan.h --- ./drivers/net/wireless/arlan.h~arlanprocfs 2003-10-08 12:24:08.000000000 -0700 +++ ./drivers/net/wireless/arlan.h 2003-10-12 19:45:46.000000000 -0700 @@ -39,13 +39,8 @@ #define ARLAN_RCV_PROMISC 1 #define ARLAN_RCV_CONTROL 2 -#ifdef CONFIG_PROC_FS extern int init_arlan_proc(void); extern void cleanup_arlan_proc(void); -#else -#define init_arlan_proc() (0) -#define cleanup_arlan_proc() do { } while (0); -#endif extern struct net_device *arlan_device[MAX_ARLANS]; extern int arlan_debug;