Received: with ECARTIS (v1.0.0; list netdev); Sat, 11 Oct 2003 20:26:35 -0700 (PDT)
Received: from mail.osdl.org (fw.osdl.org [65.172.181.6])
	by oss.sgi.com (8.12.10/8.12.10) with SMTP id h9C3Q125029401
	for <netdev@oss.sgi.com>; Sat, 11 Oct 2003 20:26:02 -0700
Received: from midway.verizon.net (build.pdx.osdl.net [172.20.1.2])
	by mail.osdl.org (8.11.6/8.11.6) with SMTP id h9C3Pfo12477;
	Sat, 11 Oct 2003 20:25:41 -0700
Date: Sat, 11 Oct 2003 20:24:33 -0700
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: davem@redhat.com, netdev@oss.sgi.com
Subject: Re: patches for PROC_FS=n (2.6.0-test7)
Message-Id: <20031011202433.72fcbd38.rddunlap@osdl.org>
In-Reply-To: <20031011194008.GA2395@mars.ravnborg.org>
References: <20031010141646.779f10bb.rddunlap@osdl.org>
	<20031011120852.13fa8ec4.davem@redhat.com>
	<20031011194008.GA2395@mars.ravnborg.org>
Organization: OSDL
X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-archive-position: 749
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: rddunlap@osdl.org
Precedence: bulk
X-list: netdev

On Sat, 11 Oct 2003 21:40:08 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:

| On Sat, Oct 11, 2003 at 12:08:52PM -0700, David S. Miller wrote:
| > On Fri, 10 Oct 2003 14:16:46 -0700
| > "Randy.Dunlap" <rddunlap@osdl.org> wrote:
| > 
| > > http://developer.osdl.org/rddunlap/patches/atmprocfs_260t7.patch
| > 
| > How can this be needed?  When procfs is disabled then
| > remove_proc_entry() is defined as "do { } while (0)", ie. a nop.
| 
| Due to this - the real offender:
| 
| from: net/atm/clip.c:
| #ifdef CONFIG_PROC_FS
| #include <linux/proc_fs.h>
| #include <linux/seq_file.h>
| #endif

ugh, thanks.

--
~Randy