Received: with ECARTIS (v1.0.0; list netdev); Sat, 11 Oct 2003 12:19:32 -0700 (PDT) Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242]) by oss.sgi.com (8.12.10/8.12.10) with SMTP id h9BJIw25008055 for ; Sat, 11 Oct 2003 12:18:59 -0700 Received: (from davem@localhost) by pizda.ninka.net (8.9.3/8.9.3) id MAA23067; Sat, 11 Oct 2003 12:13:08 -0700 Date: Sat, 11 Oct 2003 12:13:07 -0700 From: "David S. Miller" To: Stephen Hemminger Cc: jgarzik@pobox.com, netdev@oss.sgi.com Subject: Re: [PATCH] synclink -- incorrect check of register_netdev return val. Message-Id: <20031011121307.39df7c03.davem@redhat.com> In-Reply-To: <20031010103202.1c6ef5f2.shemminger@osdl.org> References: <20031009112714.18742308.shemminger@osdl.org> <20031010000158.2dc9ce78.davem@redhat.com> <20031010103202.1c6ef5f2.shemminger@osdl.org> X-Mailer: Sylpheed version 0.9.2 (GTK+ 1.2.6; sparc-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 742 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev On Fri, 10 Oct 2003 10:32:02 -0700 Stephen Hemminger wrote: > The synclink family of drivers all check for register_netdev returning > -1 when in fact it will return -EIO or -EEXIST. Also applied, thanks.