Received: with ECARTIS (v1.0.0; list netdev); Fri, 10 Oct 2003 10:33:33 -0700 (PDT) Received: from mail.osdl.org (fw.osdl.org [65.172.181.6]) by oss.sgi.com (8.12.10/8.12.10) with SMTP id h9AHWw25001432 for ; Fri, 10 Oct 2003 10:32:58 -0700 Received: from dell_ss3.pdx.osdl.net (dell_ss3.pdx.osdl.net [172.20.1.60]) by mail.osdl.org (8.11.6/8.11.6) with SMTP id h9AHWjo19551; Fri, 10 Oct 2003 10:32:45 -0700 Date: Fri, 10 Oct 2003 10:32:25 -0700 From: Stephen Hemminger To: "David S. Miller" Cc: jgarzik@pobox.com, netdev@oss.sgi.com Subject: [PATCH] hostess -- return value check for register_netdev Message-Id: <20031010103225.2177d385.shemminger@osdl.org> In-Reply-To: <20031010000158.2dc9ce78.davem@redhat.com> References: <20031009112714.18742308.shemminger@osdl.org> <20031010000158.2dc9ce78.davem@redhat.com> Organization: Open Source Development Lab X-Mailer: Sylpheed version 0.9.5claws (GTK+ 1.2.10; i686-pc-linux-gnu) X-Face: &@E+xe?c%:&e4D{>f1O<&U>2qwRREG5!}7R4;D<"NO^UI2mJ[eEOA2*3>(`Th.yP,VDPo9$ /`~cw![cmj~~jWe?AHY7D1S+\}5brN0k*NE?pPh_'_d>6;XGG[\KDRViCfumZT3@[ Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 716 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: shemminger@osdl.org Precedence: bulk X-list: netdev Another driver that checks for register_netdev returing -1 when it can return -EIO or -EEXIST. diff -Nru a/drivers/net/wan/hostess_sv11.c b/drivers/net/wan/hostess_sv11.c --- a/drivers/net/wan/hostess_sv11.c Fri Oct 10 09:58:31 2003 +++ b/drivers/net/wan/hostess_sv11.c Fri Oct 10 09:58:31 2003 @@ -337,7 +337,7 @@ d->neigh_setup = hostess_neigh_setup_dev; d->set_mac_address = NULL; - if(register_netdev(d)==-1) + if(register_netdev(d)) { printk(KERN_ERR "%s: unable to register device.\n", d->name);