Received: with ECARTIS (v1.0.0; list netdev); Sat, 30 Aug 2003 13:29:21 -0700 (PDT) Received: from www.linux.org.uk (IDENT:93@parcelfarce.linux.theplanet.co.uk [195.92.249.252]) by oss.sgi.com (8.12.9/8.12.5) with SMTP id h7UKSjWZ026481 for ; Sat, 30 Aug 2003 13:28:46 -0700 Received: from rdu74-153-143.nc.rr.com ([24.74.153.143]:33159 helo=pobox.com) by www.linux.org.uk with esmtp (Exim 4.22) id 19tBD4-0003sQ-1J; Sat, 30 Aug 2003 20:16:30 +0100 Message-ID: <3F50F805.9090805@pobox.com> Date: Sat, 30 Aug 2003 15:16:21 -0400 From: Jeff Garzik Organization: none User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk X-Accept-Language: en MIME-Version: 1.0 To: mzyngier@freesurf.fr CC: akpm@osdl.org, linux-net@vger.kernel.org, Maillist netdev Subject: Re: [PATCH][2.6] de4x5 cleanup References: <3F50E3FD.1000703@pobox.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 5411 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: jgarzik@pobox.com Precedence: bulk X-list: netdev Content-Length: 1058 Lines: 32 Marc Zyngier wrote: >>>>>>"Jeff" == Jeff Garzik writes: > > > Jeff> It looks pretty good. My big objection isn't the Space.c stuff > Jeff> but de4x5 itself. I had hoped it would be gone by now :) Oh > Jeff> well, not your fault. > > Well... I too, had hoped the tulip (and its dc21040 derivative) > driver would be the only one. While it works nicely on modern stuff > (2114[023]), it has some problems on a few of my test boxes (mostly > Alphas with onboard 21040). Well, 2.6 tulip intentionally doesn't work at all on 21040 and 21041 :) That's what de2104x driver is for. Can you give that a beating, and verify that it works for you? I know that 2114x chips with sym phys still have some issues; jamal has created a patch that fixes that (mostly updates tulip with the latest Becker phy code from Donald's tulip.c), which in turn fixes some 2114x issues on alpha. > And most of all, tulip doesn't support EISA :-). If it meant I could kill de4x5, then I would be all for adding EISA support to tulip... :) Jeff