Received: with ECARTIS (v1.0.0; list netdev); Wed, 20 Aug 2003 05:50:23 -0700 (PDT) Received: from apollo.nbase.co.il (apollo.nbase.co.il [194.90.137.2]) by oss.sgi.com (8.12.9/8.12.9) with SMTP id h7KCoDoO010642 for ; Wed, 20 Aug 2003 05:50:15 -0700 Received: from mrv.com ([194.90.139.36]) by apollo.nbase.co.il (Post.Office MTA v3.1.2 release (PO205-101c) ID# 0-44418U200L2S100) with ESMTP id AAA360; Wed, 20 Aug 2003 15:54:41 +0200 Message-ID: <3F436EE7.1030104@mrv.com> Date: Wed, 20 Aug 2003 15:51:51 +0300 From: Eran Mann User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David S. Miller" CC: netdev@oss.sgi.com Subject: Re: [patch 2.4] kernel oops on VLAN removal References: <3F424405.6020002@mrv.com> <20030819124154.75ec0383.davem@redhat.com> In-Reply-To: <20030819124154.75ec0383.davem@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 5121 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: emann@mrv.com Precedence: bulk X-list: netdev Content-Length: 773 Lines: 28 David S. Miller wrote: > On Tue, 19 Aug 2003 18:36:37 +0300 > Eran Mann wrote: > > >>The current code attempts to add a proc entry for each vlan device, >>however there is no check whether this attempt succeeded. When a device >>is unregistered it tries to remove the proc entry, if none was added >>the oops follows... > > > Patch applied to my 2.4.x tree, scheduled for 2.4.23-preX > > Can someone check out 2.6.x? > It looks the same in 2.6.0-test3. The patch applies (with small offsets) and works (the oops is much harder to trigger in 2.6.x since PROC_NDYNAMIC is increased to 16384, I had to reduce it to 4096 to trigger the oops). -- Eran Mann Senior Software Engineer MRV International Tel: 972-4-9936297 Fax: 972-4-9890430 www.mrv.com