Received: with ECARTIS (v1.0.0; list netdev); Mon, 18 Aug 2003 04:21:45 -0700 (PDT) Received: from www.linux.org.uk (IDENT:93@parcelfarce.linux.theplanet.co.uk [195.92.249.252]) by oss.sgi.com (8.12.9/8.12.9) with SMTP id h7IBLIFl004187 for ; Mon, 18 Aug 2003 04:21:20 -0700 Received: from rdu26-227-011.nc.rr.com ([66.26.227.11] helo=pobox.com) by www.linux.org.uk with esmtp (Exim 4.14) id 19neem-0006f0-EJ; Fri, 15 Aug 2003 14:30:16 +0100 Message-ID: <3F3CE05D.5080306@pobox.com> Date: Fri, 15 Aug 2003 09:30:05 -0400 From: Jeff Garzik Organization: none User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk X-Accept-Language: en MIME-Version: 1.0 To: "David S. Miller" CC: Stephen Hemminger , mikep@linuxtr.net, linux-tr@linuxtr.net, netdev@oss.sgi.com Subject: Re: [PATCH] ibmtr - get rid of MOD_INC/DEC References: <20030813174658.2c5125af.shemminger@osdl.org> <20030814205747.5fcd83d0.davem@redhat.com> In-Reply-To: <20030814205747.5fcd83d0.davem@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 4942 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: jgarzik@pobox.com Precedence: bulk X-list: netdev David S. Miller wrote: > On Wed, 13 Aug 2003 17:46:58 -0700 > Stephen Hemminger wrote: > > >>With the new module system MOD_INC/MOD_DEC are no longer necessary. >>Also changed to new module init/exit macros for function setup. >> >>The module exit code can sleep, so calling schedule_timeout is better >>than spinning. > > > Can't we lose the MODULE ifdefs too? Doubtful for ibmtr, which requires some of them for ibmtr_cs (which #includes it). Jeff