Received: with ECARTIS (v1.0.0; list netdev); Sat, 16 Aug 2003 07:46:44 -0700 (PDT)
Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242])
	by oss.sgi.com (8.12.9/8.12.9) with SMTP id h7GEkeFl025601
	for <netdev@oss.sgi.com>; Sat, 16 Aug 2003 07:46:40 -0700
Received: from pizda.ninka.net (IDENT:davem@localhost.localdomain [127.0.0.1])
	by pizda.ninka.net (8.9.3/8.9.3) with SMTP id HAA26264;
	Sat, 16 Aug 2003 07:40:15 -0700
Date: Sat, 16 Aug 2003 07:40:14 -0700
From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: da-x@gmx.net, netdev@oss.sgi.com, mhuth@mvista.com
Subject: Re: [PATCH] network device renaming sysfs fix
Message-Id: <20030816074014.46b228f5.davem@redhat.com>
In-Reply-To: <20030815093724.519779e6.shemminger@osdl.org>
References: <20030815111514.GA5228@callisto.yi.org>
	<20030815093724.519779e6.shemminger@osdl.org>
X-Mailer: Sylpheed version 0.9.2 (GTK+ 1.2.6; sparc-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-archive-position: 4874
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@redhat.com
Precedence: bulk
X-list: netdev

On Fri, 15 Aug 2003 09:37:24 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:

> The class_dev kobject name is 20 chars and IFNAMSIZ is 16, so the solution
> needs to truncate if new_name is not null terminated (all 16 chars long).
> 
> This seems like the best approach:

Patch applied, thanks everyone.

Can't the device name also change via netlink messages?
If so, do we handle that case properly?