Received: with ECARTIS (v1.0.0; list netdev); Thu, 14 Aug 2003 21:04:36 -0700 (PDT) Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242]) by oss.sgi.com (8.12.9/8.12.9) with SMTP id h7F44TFl015661 for ; Thu, 14 Aug 2003 21:04:29 -0700 Received: from pizda.ninka.net (IDENT:davem@localhost.localdomain [127.0.0.1]) by pizda.ninka.net (8.9.3/8.9.3) with SMTP id UAA22237; Thu, 14 Aug 2003 20:57:47 -0700 Date: Thu, 14 Aug 2003 20:57:47 -0700 From: "David S. Miller" To: Stephen Hemminger Cc: mikep@linuxtr.net, linux-tr@linuxtr.net, netdev@oss.sgi.com Subject: Re: [PATCH] ibmtr - get rid of MOD_INC/DEC Message-Id: <20030814205747.5fcd83d0.davem@redhat.com> In-Reply-To: <20030813174658.2c5125af.shemminger@osdl.org> References: <20030813174658.2c5125af.shemminger@osdl.org> X-Mailer: Sylpheed version 0.9.2 (GTK+ 1.2.6; sparc-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 4841 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev On Wed, 13 Aug 2003 17:46:58 -0700 Stephen Hemminger wrote: > With the new module system MOD_INC/MOD_DEC are no longer necessary. > Also changed to new module init/exit macros for function setup. > > The module exit code can sleep, so calling schedule_timeout is better > than spinning. Can't we lose the MODULE ifdefs too?