Received: with ECARTIS (v1.0.0; list netdev); Wed, 02 Apr 2003 07:02:29 -0800 (PST) Received: from e3.ny.us.ibm.com (e3.ny.us.ibm.com [32.97.182.103]) by oss.sgi.com (8.12.3/8.12.5) with SMTP id h32F1krX008727 for ; Wed, 2 Apr 2003 07:01:53 -0800 Received: from northrelay03.pok.ibm.com (northrelay03.pok.ibm.com [9.56.224.151]) by e3.ny.us.ibm.com (8.12.9/8.12.2) with ESMTP id h32F0E9k135280; Wed, 2 Apr 2003 10:00:14 -0500 Received: from d01ml072.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by northrelay03.pok.ibm.com (8.12.8/NCO/VER6.5) with ESMTP id h32F057J062192; Wed, 2 Apr 2003 10:00:11 -0500 Subject: Re: [PATCH] IPSec: Use of "sizeof" for header sizes, part II To: YOSHIFUJI Hideaki Cc: davem@redhat.com, kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com, "Hideaki YOSHIFUJI" X-Mailer: Lotus Notes Release 5.0.11 July 24, 2002 Message-ID: From: "Tom Lendacky" Date: Wed, 2 Apr 2003 09:00:03 -0600 X-MIMETrack: Serialize by Router on D01ML072/01/M/IBM(Release 5.0.11 +SPRs MIAS5EXFG4, MIAS5AUFPV and DHAG4Y6R7W, MATTEST |November 8th, 2002) at 04/02/2003 10:00:12 AM MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-archive-position: 2150 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: toml@us.ibm.com Precedence: bulk X-list: netdev Content-Length: 271 Lines: 11 I just noticed the use of the AH_HLEN_NOICV #define which is hardcoded to be 12. The patch should probably take the change to the esp header and apply it to the auth header also (as shown in an earlier post) and then eliminate the hardcoding of the 12. Thanks, Tom