Received: with ECARTIS (v1.0.0; list netdev); Thu, 10 Oct 2002 16:43:25 -0700 (PDT)
Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242])
	by oss.sgi.com (8.12.5/8.12.5) with SMTP id g9ANhMtG015987
	for <netdev@oss.sgi.com>; Thu, 10 Oct 2002 16:43:23 -0700
Received: from localhost (IDENT:davem@localhost.localdomain [127.0.0.1])
	by pizda.ninka.net (8.9.3/8.9.3) with ESMTP id QAA07832;
	Thu, 10 Oct 2002 16:36:46 -0700
Date: Thu, 10 Oct 2002 16:36:46 -0700 (PDT)
Message-Id: <20021010.163646.35014672.davem@redhat.com>
To: bcrl@redhat.com
Cc: netdev@oss.sgi.com
Subject: Re: [patch] add iocb to network protocols
From: "David S. Miller" <davem@redhat.com>
In-Reply-To: <20021010194025.B13432@redhat.com>
References: <20021010183528.A13432@redhat.com>
	<20021010.162240.102769920.davem@redhat.com>
	<20021010194025.B13432@redhat.com>
X-FalunGong: Information control.
X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 631
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@redhat.com
Precedence: bulk
X-list: netdev

   From: Benjamin LaHaise <bcrl@redhat.com>
   Date: Thu, 10 Oct 2002 19:40:25 -0400

   On Thu, Oct 10, 2002 at 04:22:40PM -0700, David S. Miller wrote:
   > 
   > +#include <net/scm.h>	/* for sock_iocb */
   > 
   > What is this?
   
   The private area of an iocb for network operations contains a struct 
   scm_cookie.

I know this.  But the comment is wrong, when you say "for FOO"
next to an include that means "I'm including this to get the
definition of FOO".

Just delete the comment entirely, it really isn't needed.

Otherwise looks ok at first glance.