Received: (from majordomo@localhost) by oss.sgi.com (8.11.2/8.11.3) id g1DCjKE09167 for netdev-outgoing; Wed, 13 Feb 2002 04:45:20 -0800 Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242]) by oss.sgi.com (8.11.2/8.11.3) with SMTP id g1DCjH909163 for ; Wed, 13 Feb 2002 04:45:17 -0800 Received: from localhost (IDENT:davem@localhost.localdomain [127.0.0.1]) by pizda.ninka.net (8.9.3/8.9.3) with ESMTP id DAA03270; Wed, 13 Feb 2002 03:43:24 -0800 Date: Wed, 13 Feb 2002 03:43:24 -0800 (PST) Message-Id: <20020213.034324.23011197.davem@redhat.com> To: jgarzik@mandrakesoft.com Cc: ak@suse.de, linux-net@vger.kernel.org, netdev@oss.sgi.com, kuznet@ms2.inr.ac.ru Subject: Re: IFF_PROMISC bug? From: "David S. Miller" In-Reply-To: <3C6A2789.5DCC1C8F@mandrakesoft.com> References: <3C6A1EF5.1BF97B99@mandrakesoft.com> <20020213.001736.03366378.davem@redhat.com> <3C6A2789.5DCC1C8F@mandrakesoft.com> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-netdev@oss.sgi.com Precedence: bulk Content-Length: 862 Lines: 20 From: Jeff Garzik Date: Wed, 13 Feb 2002 03:44:57 -0500 [sigh, I meant to have said that we can support IFF_PROMISC for SIOCGIFFLAGS -only-, until the end of time. I agree with you that SIOCSIFFLAGS+IFF_PROMISC clearly is unsupportable.] Then you will break more than what you claim is broken right now. At least the current code RESPECTS setting IFF_PROMISC if an app uses SIOCSIFFLAGS to do it, your version would not. I think you'll be breaking more apps that way, in fact right off the bat your version will break all current NMAP binaries out there. That's just the first thing I checked, there are surely several other examples. The more and more I look at this situation, the more and more I respect Alexey's decision to implement things how they are now. It is the the only reasonable choice, really...