Received: (from majordomo@localhost) by oss.sgi.com (8.11.2/8.11.3) id f6VIp3106798 for netdev-outgoing; Tue, 31 Jul 2001 11:51:03 -0700 Received: from ghanima.endorphin.org ([62.116.8.197]) by oss.sgi.com (8.11.2/8.11.3) with SMTP id f6VIp2V06789 for ; Tue, 31 Jul 2001 11:51:02 -0700 Received: (qmail 8467 invoked by uid 1000); 31 Jul 2001 18:51:01 -0000 Date: Tue, 31 Jul 2001 20:51:01 +0200 From: clemens To: kuznet@ms2.inr.ac.ru Cc: Pekka Savola , therapy@endorphin.org, netdev@oss.sgi.com, linux-kernel@vger.redhat.com, davem@redhat.com Subject: Re: missing icmp errors for udp packets Message-ID: <20010731205101.B8211@ghanima.endorphin.org> References: <200107311833.WAA09598@ms2.inr.ac.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200107311833.WAA09598@ms2.inr.ac.ru> User-Agent: Mutt/1.3.18i Sender: owner-netdev@oss.sgi.com Precedence: bulk Content-Length: 549 Lines: 16 On Tue, Jul 31, 2001 at 10:33:56PM +0400, kuznet@ms2.inr.ac.ru wrote: > Hello! > > > If you reboot the computer, the _first_ ping/scan attempt will not return > > icmp dest unreachable. > Hmm... how fast after reboot? your patch will not prevent the first ping to empty the token bucket, because burst is still 0, which is larger than dst->rate_token, and since XRLIM_BURST_FACTOR times the timeout (which is 6*0=0 in that case) is the token maximum, it will be truncated to 0, causing the following packets (if in time) to be dropped. clemens