Received: (from majordomo@localhost) by oss.sgi.com (8.11.3/8.11.3) id f54Asj707745 for netdev-outgoing; Mon, 4 Jun 2001 03:54:45 -0700 Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242]) by oss.sgi.com (8.11.3/8.11.3) with SMTP id f54Asih07742 for ; Mon, 4 Jun 2001 03:54:44 -0700 Received: (from davem@localhost) by pizda.ninka.net (8.9.3/8.9.3) id DAA12320; Mon, 4 Jun 2001 03:54:42 -0700 From: "David S. Miller" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15131.26866.794001.525719@pizda.ninka.net> Date: Mon, 4 Jun 2001 03:54:42 -0700 (PDT) To: Manfred Spraul Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com Subject: Re: multicast hash incorrect on big endian archs In-Reply-To: <3B1B564E.D83A741A@colorfullife.com> References: <3B1A9558.2DBAECE7@colorfullife.com> <15130.61778.471925.245018@pizda.ninka.net> <3B1B3268.2A02D2C@colorfullife.com> <3B1B564E.D83A741A@colorfullife.com> X-Mailer: VM 6.75 under 21.1 (patch 13) "Crater Lake" XEmacs Lucid Sender: owner-netdev@oss.sgi.com Precedence: bulk Content-Length: 449 Lines: 17 Manfred Spraul writes: > That could cause alignment problems. > <<< from starfire.c > { > long filter_addr; > u16 mc_filter[32] __attribute__ ((aligned(sizeof(long)))); > <<< > set_bit requires word alignment, but without the __attibute__ the > compiler would only guarantee 16-bit alignment. IMHO ugly. Correction, it requires "long" alignment and that is 64-bits on several platforms. Later, David S. Miller davem@redhat.com