Message-ID: <39521C2C.B11140A2@uow.edu.au>
Date:   Fri, 23 Jun 2000 00:01:16 +1000
From:   Andrew Morton <andrewm@uow.edu.au>
MIME-Version: 1.0
To:     "netdev@oss.sgi.com" <netdev@oss.sgi.com>
Subject: Re: modular net drivers
References: Your message of "Thu,
            22 Jun 2000 08:44:29 -0400." <39520A2D.498A3E39@mandrakesoft.com> <2460.961679037@ocs3.ocs-net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-netdev@oss.sgi.com
Precedence: bulk

Keith Owens wrote:
> 
> Other calls to module functions do not run under the big kernel lock.
> Instead they are meant to call open() first which bumps the reference
> count.

The problem with the net drivers is that they are "opened" within the
module constructor, "closed" with the module destructor and their "open"
and "close" methods don't (can't) manipulate the refcounts.

You see, netdevice.open() is a misnomer.  It simply switches an
existing, already-open netdevice from 'down' to 'up'.  It should be
called 'start' (cf netdevice.stop).

It's register_netdevice() which registers a device with the kernel and
makes all its entry points available for use.  register_netdevice is
called from within module_init().

Seen in this light, incrementing the refcount within netdevice.open() is
kinda arbitrary.  All the other netdevice methods should also increment
the refcount (yes, racy).

Sigh.

rm /sbin/rmmod.  There.  Fixed.