Received: with ECARTIS (v1.0.0; list kdb); Fri, 01 Jun 2007 12:23:34 -0700 (PDT) Received: from vms042pub.verizon.net (vms042pub.verizon.net [206.46.252.42]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l51JNTWt015643 for ; Fri, 1 Jun 2007 12:23:29 -0700 Received: from wf-rch.minyard.local ([71.97.113.70]) by vms042.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JIZ00JSK1UP1HH5@vms042.mailsrvcs.net> for kdb@oss.sgi.com; Fri, 01 Jun 2007 14:23:13 -0500 (CDT) Received: from i2 (i2.minyard.local [192.168.27.126]) by wf-rch.minyard.local (Postfix) with ESMTP id 9E434471F6; Fri, 01 Jun 2007 14:23:21 -0500 (CDT) Date: Fri, 01 Jun 2007 14:23:12 -0500 From: Corey Minyard Subject: [PATCH] KDB x86_64 should use register_die_notifier To: kdb@oss.sgi.com Cc: cminyard@mvista.com Reply-to: minyard@acm.org Message-id: <20070601192312.GA21882@localdomain> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) Content-Transfer-Encoding: 8bit X-archive-position: 1219 X-ecartis-version: Ecartis v1.0.0 Sender: kdb-bounce@oss.sgi.com Errors-to: kdb-bounce@oss.sgi.com X-original-sender: minyard@acm.org Precedence: bulk X-list: kdb I was working on KDB and ran into a problem on initialization on x86_64. There's some magic that happens with register_die_notifier to make it work correctly. die_chain should not be directly accessed. KDB should go through register_die_notifier. Signed-off-by: Corey Minyard Index: linux-2.6.21/arch/x86_64/kdb/kdbasupport.c =================================================================== --- linux-2.6.21.orig/arch/x86_64/kdb/kdbasupport.c +++ linux-2.6.21/arch/x86_64/kdb/kdbasupport.c @@ -915,7 +915,7 @@ kdba_init(void) { kdb_register("pt_regs", kdba_pt_regs, "address", "Format struct pt_regs", 0); kdb_register("cpu_pda", kdba_cpu_pda, "", "Format struct cpu_pda", 0); - atomic_notifier_chain_register(&die_chain, &kdba_notifier); + register_die_notifier(&kdba_notifier); return; } --------------------------- Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.