CVS log for xfs-linux/xfs_dir2_sf.h

Up to [Development] / xfs-linux

Request diff between arbitrary revisions

Default branch: MAIN
Current tag: HEAD

Revision 1.25 / (download) - annotate - [select for diffs], Fri Jun 6 06:17:18 2008 UTC (9 years, 4 months ago) by tes.longdrop.melbourne.sgi.com
Branch: MAIN
CVS Tags: HEAD
Changes since 1.24: +3 -3 lines
Diff to previous 1.24 (colored)

Pack some shortform dir2 structures for the ARM old ABI architecture.

This should fix the longstanding issues with xfs and old ABI
arm boxes, which lead to various asserts and xfs shutdowns,
and for which an (incorrect) patch has been floating around
for years.

I've verified this patch by comparing the on-disk structure
layouts using pahole from the dwarves package, as well as
running through a bit of xfsqa under qemu-arm, modified so
that the check/repair phase after each test actually executes
check/repair from the x86 host, on the filesystem populated
by the arm emulator.  Thus far it all looks good.

There are 2 other structures with extra padding at the end,
but they don't seem to cause trouble.  I suppose they could
be packed as well: xfs_dir2_data_unused_t and xfs_dir2_sf_t.

Note that userspace needs a similar treatment, and any
filesystems which were running with the previous rogue
"fix" will now see corruption (either in the kernel, or
during xfs_repair) with this fix properly in place; it
may be worth teaching xfs_repair to identify and fix that
specific issue.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Merge of xfs-linux-melb:xfs-kern:31280a by kenmcd.

  Fix up some dir2 shortform structures for ARM using packing

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.