CVS log for xfs-linux/linux-2.6/xfs_buf.c

Up to [Development] / xfs-linux / linux-2.6

Request diff between arbitrary revisions

Default branch: MAIN
Current tag: HEAD

Revision 1.263 / (download) - annotate - [select for diffs], Fri Oct 10 15:26:05 2008 UTC (9 years ago) by tes.longdrop.melbourne.sgi.com
Branch: MAIN
CVS Tags: HEAD
Changes since 1.262: +2 -1 lines
Diff to previous 1.262 (colored)

fix barrier fail detection

Currently we disable barriers as soon as we get a buffer in xlog_iodone
that has the XBF_ORDERED flag cleared.  But this can be the case not only
for buffers where the barrier failed, but also the first buffer of a
split log write in case of a log wraparound.  Due to the disabled
barriers we can easily get directory corruption on unclean shutdowns.
So instead of using this check add a new buffer flag for failed barrier
writes.

This is a regression vs 2.6.26 caused by patch to use the right macro
to check for the ORDERED flag, as we previously got true returned for
every buffer.

Thanks to Toei Rei for reporting the bug.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of xfs-linux-melb:xfs-kern:32298a by kenmcd.

  fix barrier fail detection

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.