Bug 781 – xfs_quota doesn't report success/failure in exit status

Bug 781 - xfs_quota doesn't report success/failure in exit status


Summary:	xfs_quota doesn't report success/failure in exit status

Status:	RESOLVED FIXED

Product:	XFS
Classification:	Unclassified
Component:	xfsprogs
Version:	Current
Platform:	PC Linux

Importance:	P2 enhancement
Target Milestone:	---
Assigned To:	XFS power people
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-04-18 06:31 CDT by Arkadiusz Miskiewicz
Modified:	2008-12-30 17:17 CST (History)
CC List:	0 users

See Also:

Attachments
add exitstatus 1 where needed (10.73 KB, patch) 2008-04-19 00:52 CDT, Arkadiusz Miskiewicz	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arkadiusz Miskiewicz 2008-04-18 06:31:38 CDT

xfs_quota (posibly other tools?) doesn't report success/failure in exit status 
which prevents it from being used in automated scripts easily.

Please add exit status that correspond to job success/failure.

[root@x ~]# LC_ALL=C /usr/sbin/xfs_quota -x -c "limit -u bsoft=1024M 
bhard=1074M 10000" /home; echo $?
xfs_quota: cannot set limits: Function not implemented
0
[root@x ~]#

xfsprogs 2.9.7

Comment 1 Arkadiusz Miskiewicz 2008-04-19 00:52:21 CDT

Created attachment 237 [details]
add exitstatus 1 where needed

Here is proposed patch. Someone needs to ensure that it adds existatus = 1 only
in needed places.

ps. Could anyone change this bugzilla configuration to allow email address
changes in user accounts? My registered email here no longer works and I can't
change it unfortunately. I also didn't find bugzilla administrator email
address on sgi websites...

Comment 2 Christoph Hellwig 2008-12-30 17:17:14 CST

Your patch is now in the development tree at:

http://git.kernel.org/?p=fs/xfs/xfsprogs-dev.git