Bug 766 – xfsprogs-2.9.3 needs libphtread in more places

Bug 766 - xfsprogs-2.9.3 needs libphtread in more places


Summary:	xfsprogs-2.9.3 needs libphtread in more places

Status:	RESOLVED FIXED

Product:	XFS
Classification:	Unclassified
Component:	xfsprogs
Version:	unspecified
Platform:	Other Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	XFS power people
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-08-31 21:11 CDT by Mike Frysinger
Modified:	2008-12-25 04:36 CST (History)
CC List:	0 users

See Also:

Attachments
libpthread for xfsprogs Makefiles (2.96 KB, patch) 2007-09-06 22:07 CDT, Barry Naujok	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Frysinger 2007-08-31 21:11:08 CDT

not sure if this is an error in the source or in the build, but in the new 2.9.3
release, pretty much all the binaries need the pthread functions by way of
common lib files

cache.c in libxfs uses pthread_mutex_trylock and cache.o gets pulled in for most
binaries like xfs_db but -lpthread is not utilized on the link line

Comment 1 Barry Naujok 2007-09-02 19:21:18 CDT

Thinking more about this... libxfs should #ifdef the use of pthread
stuff. Only xfs_repair needs pthread calls. All other users of
libxfs don't need it.

Comment 2 Mike Frysinger 2007-09-02 19:25:27 CDT

that'd lead to some pretty fugly code ... maybe a local header that macro's away
all the pthread stuff ...

Comment 3 Barry Naujok 2007-09-06 22:07:19 CDT

Created attachment 232 [details]
libpthread for xfsprogs Makefiles

Can you try the attached patch to see if it fixes your problems?

Comment 4 Mike Frysinger 2007-09-06 22:19:13 CDT

you want libpthread after librt, but otherwise that is pretty much what i've
been using in Gentoo ... i just figured you guys would want to fix it a
different way

Comment 5 Christoph Hellwig 2008-12-25 04:36:43 CST

Barry's patch is in now, including Mike's suggested fixes.