Re: [PATCH 10/12] new iov_iter flavour: pipe-backed

To:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject:	Re: [PATCH 10/12] new iov_iter flavour: pipe-backed
From:	Miklos Szeredi <miklos@xxxxxxxxxx>
Date:	Fri, 30 Sep 2016 09:30:21 +0200
Cc:	Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, CAI Qian <caiqian@xxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oq6uKi92V07CIJI+sTpAQFJqMudWz8gL4OVbXeKADTE=; b=USANp6OVCrg4VfVJlxykwHiZQoJBXywa9t187K0EICGCVwn8nxZo2iJj0YWXEfcoyo AhIsJldjjDZceydp/ySAK3PXRwosd3JZfeQQYKmvL5IAnvcZ56TxugiLD733/wq3OE+E lhng9VUbSm/VPjhsirNZn0cvJoNnr352rZ3Jo=
In-reply-to:	<20160929225003.GQ19539@xxxxxxxxxxxxxxxxxx>
References:	<20160914042559.GC2356@xxxxxxxxxxxxxxxxxx> <20160917082007.GA6489@xxxxxxxxxxxxxxxxxx> <20160917190023.GA8039@xxxxxxxxxxxxxxxxxx> <20160923190032.GA25771@xxxxxxxxxxxxxxxxxx> <20160923190326.GB2356@xxxxxxxxxxxxxxxxxx> <CA+55aFxzPH2AYvDVWSAomO6bN_sW4+qDv87Xbq8XHMyvBEYe+w@xxxxxxxxxxxxxx> <20160923201025.GJ2356@xxxxxxxxxxxxxxxxxx> <CA+55aFyr-X_6FcWkSXBUcxV0p1BUZw8d=46wawv2x+8y7f8YcQ@xxxxxxxxxxxxxx> <20160924040117.GP2356@xxxxxxxxxxxxxxxxxx> <CAELBmZDpm635PcTPQfnpLGs2P4bfT6JU+DEuFu9pBut=uzOLHw@xxxxxxxxxxxxxx> <20160929225003.GQ19539@xxxxxxxxxxxxxxxxxx>

On Fri, Sep 30, 2016 at 12:50 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Sep 29, 2016 at 10:53:55PM +0200, Miklos Szeredi wrote:
>
>> The EFAULT logic seems to be missing across the board.  And callers
>> don't expect a zero return value.  Most will loop indefinitely.
>
> Nope.  copy_page_to_iter() *never* returns -EFAULT.  Including the iovec
> one - check copy_page_to_iter_iovec().  Any caller that does not expect
> a zero return value from that primitive is a bug, triggerable as soon as
> you feed it an iovec with NULL ->iov_base.

Right.

I was actually looking at iov_iter_get_pages() callers...

Thanks,
Miklos

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), (continued) Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Nicholas Piggin Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Chuck Lever [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Miklos Szeredi Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro [PATCH 06/12] new helper: add_to_pipe(), Al Viro Re: [PATCH 06/12] new helper: add_to_pipe(), Miklos Szeredi [PATCH 10/12] new iov_iter flavour: pipe-backed, Al Viro Re: [PATCH 10/12] new iov_iter flavour: pipe-backed, Miklos Szeredi Re: [PATCH 10/12] new iov_iter flavour: pipe-backed, Al Viro Re: [PATCH 10/12] new iov_iter flavour: pipe-backed, Miklos Szeredi <= [PATCH 11/12] switch generic_file_splice_read() to use of ->read_iter(), Al Viro [PATCH 12/12] switch default_file_splice_read() to use of pipe-backed iov_iter, Al Viro [PATCH 05/11] skb_splice_bits(): get rid of callback, Al Viro [PATCH 06/11] new helper: add_to_pipe(), Al Viro [PATCH 07/11] fuse_dev_splice_read(): switch to add_to_pipe(), Al Viro [PATCH 08/11] cifs: don't use memcpy() to copy struct iov_iter, Al Viro [PATCH 09/11] fuse_ioctl_copy_user(): don't open-code copy_page_{to,from}_iter(), Al Viro Re: [PATCH 09/11] fuse_ioctl_copy_user(): don't open-code copy_page_{to,from}_iter(), Miklos Szeredi [PATCH 10/11] new iov_iter flavour: pipe-backed, Al Viro [PATCH 11/11] switch generic_file_splice_read() to use of ->read_iter(), Al Viro

Previous by Date:	Your Best PCB supplier---Sunny2016-09-30 13:57:03, hongmypcb6@xxxxxxx
Next by Date:	Re: [ANNOUNCE] xfs: for-next branch updated to 2e405cd, Eryu Guan
Previous by Thread:	Re: [PATCH 10/12] new iov_iter flavour: pipe-backed, Al Viro
Next by Thread:	[PATCH 11/12] switch generic_file_splice_read() to use of ->read_iter(), Al Viro
Indexes:	[Date] [Thread] [Top] [All Lists]